Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kubectl fish shell completion #92989

Merged
merged 2 commits into from Aug 25, 2021
Merged

add kubectl fish shell completion #92989

merged 2 commits into from Aug 25, 2021

Conversation

WLun001
Copy link
Contributor

@WLun001 WLun001 commented Jul 11, 2020 •
edited by soltysh

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
add fish shell completion, kubectl completion fish

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add fish shell completion to kubectl

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 11, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @WLun001!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @WLun001. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 11, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 11, 2020
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 11, 2020
@WLun001
Copy link
Contributor Author

WLun001 commented Jul 11, 2020

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 11, 2020
@marckhouzam
Copy link
Member

This is great!
I believe @brianpursley had looked at this, so he might be interested.

@eddiezane
Copy link
Member

/ok-to-test

@brianpursley @knight42 not sure where this stands with what y'all were cooking up.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/apiserver area/cloudprovider area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021
@knight42
Copy link
Member

/priority important-longterm
/triage accepted
/assign @eddiezane

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 10, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021
@szpak szpak mentioned this pull request Aug 15, 2021
Closed
@WLun001 WLun001 requested a review from knight42 August 23, 2021 06:49
knight42
knight42 approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@knight42 knight42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2021
@pacoxu pacoxu added this to Needs Approver in SIG CLI Aug 25, 2021
@eddiezane
Copy link
Member

Thank you for this!

Can you please edit your top level comment and add a release note?

Add fish shell completion to kubectl

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianpursley, chenrui333, eddiezane, knight42, WLun001

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 25, 2021 •
edited

@WLun001: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-kubernetes-files-remake 6926b6b6584723936d4b43719188dc6524372b32 link /test pull-kubernetes-files-remake
pull-kubernetes-e2e-azure-disk 6926b6b6584723936d4b43719188dc6524372b32 link /test pull-kubernetes-e2e-azure-disk
pull-kubernetes-e2e-azure-disk-windows 6926b6b6584723936d4b43719188dc6524372b32 link /test pull-kubernetes-e2e-azure-disk-windows
pull-kubernetes-e2e-azure-file 6926b6b6584723936d4b43719188dc6524372b32 link /test pull-kubernetes-e2e-azure-file
pull-kubernetes-e2e-gci-gce-autoscaling 6926b6b6584723936d4b43719188dc6524372b32 link /test pull-kubernetes-e2e-gci-gce-autoscaling

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eddiezane
Copy link
Member

These failures look like a hiccup without any output.

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/92989/pull-kubernetes-e2e-gci-gce-autoscaling/1304034377704935424/

/retest

@k8s-ci-robot k8s-ci-robot merged commit cd80d70 into kubernetes:master Aug 25, 2021
SIG CLI automation moved this from Needs Approver to Done Aug 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 25, 2021
@WLun001 WLun001 deleted the fish-completion branch August 26, 2021 06:24
@zikhan zikhan mentioned this pull request Sep 3, 2021
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 10, 2021
@brianpursley brianpursley mentioned this pull request Jan 10, 2022
Merged
@mk46 mk46 mentioned this pull request May 2, 2022
Closed
yurrriq added a commit to yurrriq/dotfiles that referenced this pull request Mar 4, 2023
@yurrriq
fix: drop fish-kubectl-completions
23d5e8a 
kubectl supports fish completions since v1.23.0 and nixpkgs since 22.05

- kubernetes/kubernetes#92989
- NixOS/nixpkgs#169508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiezane eddiezane eddiezane approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@knight42 knight42 knight42 approved these changes

@brianpursley brianpursley brianpursley approved these changes

@soltysh soltysh Awaiting requested review from soltysh

@zhouya0 zhouya0 Awaiting requested review from zhouya0

Assignees

@soltysh soltysh

@eddiezane eddiezane

@knight42 knight42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@WLun001 @k8s-ci-robot @marckhouzam @eddiezane @liggitt @brianpursley @chenrui333 @fejta-bot @knight42 @soltysh