Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to create an audit log file named "-" #103875

Merged
merged 1 commit into from Jul 26, 2021
Merged

Do not try to create an audit log file named "-" #103875

merged 1 commit into from Jul 26, 2021

Conversation

andrewrynhard
Copy link
Contributor

@andrewrynhard andrewrynhard commented Jul 23, 2021 •
edited by liggitt

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes --audit-log-path=- support.
It now logs to stdout as in 1.21.

This PR should be accredited to @AlekSi. I am merely creating the PR for him since there is an issue with his CLA.

Fixes a regression setting --audit-log-path=- to log to stdout in 1.22 pre-release builds

@andrewrynhard
Do not try to create an audit log file named "-"
7728428 
That PR fixes --audit-log-path=- support.
It now logs to stdout as in 1.21.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 23, 2021
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 23, 2021
This was referenced Jul 23, 2021
Closed
Closed
@AlekSi
Copy link

AlekSi commented Jul 23, 2021

/sig api-machinery auth

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 23, 2021
@liggitt
Copy link
Member

liggitt commented Jul 23, 2021

/lgtm
/approve
/milestone v1.22
/kind regression

@k8s-ci-robot k8s-ci-robot added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Jul 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 23, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2021
@liggitt
Copy link
Member

liggitt commented Jul 23, 2021

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewrynhard, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@liggitt
Copy link
Member

liggitt commented Jul 23, 2021

Thanks for the PR, please also cherry-pick to release-1.22 using hack/cherry_pick_pull.sh

@andrewrynhard
Copy link
Contributor Author

Thanks for the PR, please also cherry-pick to release-1.22 using hack/cherry_pick_pull.sh

The script failed, but I created it manually: #103878 ... not sure if it is missing any magic that the hack script does.

@liggitt liggitt mentioned this pull request Jul 23, 2021
Merged
@pacoxu
Copy link
Member

pacoxu commented Jul 25, 2021

/retest

1 similar comment
@pacoxu
Copy link
Member

pacoxu commented Jul 26, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit ee5df7c into kubernetes:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcullen cjcullen Awaiting requested review from cjcullen

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrewrynhard @AlekSi @liggitt @k8s-ci-robot @pacoxu