Fix name for Pods of NonIndexed Jobs #105676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/apps
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Change-Id: I0ea4685a82f4cdec0caab362d52144476652f95a
alculquicondor
force-pushed
the
job-name
branch
from
c6031ff
to
4ef9d18
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Oct 21, 2021
|
What would it take to get this backported to the next 1.22.x release? This is causing pod creation failure with certain job names as seen here. |
|
Oh, please create a cherry-pick https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md |
|
In our effort to support all K8s versions, we found a small fix on our side to work with this issue, so it can wait for 1.23 from my perspective. |
|
Sg, I'm happy to lgtm if you send the cherry-pick |
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 28, 2022
…y-pick-of-#105676-upstream-release-1.22 Automated cherry pick of #105676: Fix name for Pods of NonIndexed Jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Removes generate name from NonIndexed Jobs. Otherwise, the name has the form:
job-name--1-where
-1comes from the invalid completion index.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This was accidentally added in #101601. I'm pretty sure this is just a cosmetic issue: pods would still be created because podGenerateNameWithIndex already truncates the names to fit the pod name limits.
Does this PR introduce a user-facing change?