Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support more than 100 disk mounts on Windows #105673

Merged
merged 1 commit into from Oct 15, 2021
Merged

support more than 100 disk mounts on Windows #105673

merged 1 commit into from Oct 15, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

support more than 100 disk mounts on Windows

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/kind bug
/assign @jingxu97
/priority important-soon
/sig windows
/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-containerd

Does this PR introduce a user-facing change?

support more than 100 disk mounts on Windows

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

support more than 100 disk mounts on Windows

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 14, 2021
@andyzhangx
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 14, 2021
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-containerd

@jingxu97
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 14, 2021
@lizhuqi
Copy link
Contributor

lizhuqi commented Oct 14, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@lizhuqi: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jingxu97, lizhuqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lizhuqi
Copy link
Contributor

lizhuqi commented Oct 14, 2021

This PR will also fix kubernetes/mount-utils#2

@lizhuqi lizhuqi mentioned this pull request Oct 14, 2021
Closed
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 15, 2021 •
edited

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-aks-engine-azure-disk-windows-containerd a6253e6 link false /test pull-kubernetes-e2e-aks-engine-azure-disk-windows-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx mentioned this pull request Oct 15, 2021
Closed
@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 655c04d into kubernetes:master Oct 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 15, 2021
This was referenced Oct 15, 2021
Merged
Merged
@marosset marosset added this to Done (v1.23) in SIG-Windows Oct 21, 2021
@andyzhangx andyzhangx mentioned this pull request Nov 5, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 5, 2021
@k8s-ci-robot
Merge pull request #105693 from andyzhangx/automated-cherry-pick-of-#…
ffeaf9b 
…105673-upstream-release-1.21

Automated cherry pick of #105673: support more than 100 disk mounts on Windows
k8s-ci-robot added a commit that referenced this pull request Nov 5, 2021
@k8s-ci-robot
Merge pull request #105692 from andyzhangx/automated-cherry-pick-of-#…
dccaa29 
…105673-upstream-release-1.22

Automated cherry pick of #105673: support more than 100 disk mounts on Windows
k8s-ci-robot added a commit that referenced this pull request Nov 12, 2021
@k8s-ci-robot
Merge pull request #106171 from andyzhangx/automated-cherry-pick-of-#…
82e6210 
…105673-upstream-release-1.20

Automated cherry pick of #105673: support more than 100 disk mounts on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Windows
  
Done (v1.23)
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andyzhangx @jingxu97 @lizhuqi @k8s-ci-robot @k8s-triage-robot