Make some scheduler metrics stable #105941

rezakrimi · 2021-10-27T18:58:41Z

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #105861

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

Graduating `pending_pods`, `preemption_attempts_total`, `preemption_victims` and `schedule_attempts_total` metrics to stable. Also `e2e_scheduling_duration_seconds` is renamed to `scheduling_attempt_duration_seconds` and the latter is graduated to stable.

k8s-ci-robot · 2021-10-27T18:58:49Z

Welcome @rezakrimi!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-10-27T18:58:50Z

Hi @rezakrimi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alculquicondor · 2021-10-27T21:41:22Z

/ok-to-test

This needs a release note

alculquicondor · 2021-10-27T21:41:56Z

/retitle Make some scheduler metrics stable

rezakrimi · 2021-10-28T15:15:57Z

/retest

rezakrimi · 2021-10-28T19:25:52Z

/retest

alculquicondor

/approve
/lgtm
for scheduling

pkg/scheduler/metrics/metrics.go

rezakrimi · 2021-10-29T20:01:20Z

@logicalhan Can you please review this?

logicalhan · 2021-11-01T16:03:47Z

pkg/scheduler/metrics/profile_metrics.go

@@ -44,5 +44,6 @@ func PodScheduleError(profile string, duration float64) {

 func observeScheduleAttemptAndLatency(result, profile string, duration float64) {
 	e2eSchedulingLatency.WithLabelValues(result, profile).Observe(duration)
+	schedulingLatency.WithLabelValues(result, profile).Observe(duration)


I'm not super comfortable with setting a metric to stable immediately in the same PR that it is introduced.. can we bake this a little?

Fine with me. FYI @vantuvt

@logicalhan, in case it wasn't clear, this is just a "rename" by duplication+deprecation of old metric.

@logicalhan Also wanted to point out that this kind of renaming+making stable has been done before #99785

I also don't think we should go through another round of Alpha stability when adjusting a metric before it graduates to stable. As a matter of fact, Kubernetes resources can also be modified during the graduation process to GA.

oomichi

It would be useful to write some release-note for this change.

pkg/scheduler/metrics/metrics.go

alculquicondor · 2021-11-04T15:24:00Z

Please add a release note

alculquicondor · 2021-11-04T15:25:36Z

ahh, you have to put it in between ticks:

 ```release-note

rezakrimi · 2021-11-04T15:27:34Z

ahh, you have to put it in between ticks:
 ```release-note

Done

alculquicondor · 2021-11-04T15:33:32Z

/lgtm

logicalhan

/lgtm
/approve

logicalhan · 2021-11-04T16:08:35Z

pkg/scheduler/metrics/profile_metrics.go

@@ -44,5 +44,6 @@ func PodScheduleError(profile string, duration float64) {

 func observeScheduleAttemptAndLatency(result, profile string, duration float64) {
 	e2eSchedulingLatency.WithLabelValues(result, profile).Observe(duration)
+	schedulingLatency.WithLabelValues(result, profile).Observe(duration)


k8s-ci-robot · 2021-11-04T16:09:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, logicalhan, rezakrimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/scheduler/OWNERS~~ [alculquicondor]
~~test/instrumentation/testdata/OWNERS~~ [logicalhan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dashpole · 2021-11-04T16:45:30Z

/triage accepted

alculquicondor · 2022-04-19T16:11:38Z

@wojtek-t is the renamed metric used somehow in the performance dashboards?

I couldn't find any usage using github search https://github.com/search?q=org%3Akubernetes+scheduler_e2e_scheduling_duration_seconds&type=code

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 27, 2021

k8s-ci-robot requested review from ahg-g and andyxning October 27, 2021 19:00

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2021

k8s-ci-robot changed the title ~~issue#105861: making scheduler metrics stable~~ Make some scheduler metrics stable Oct 27, 2021

rezakrimi force-pushed the issue/105861 branch from e842783 to 94cfb0a Compare October 28, 2021 15:14

rezakrimi force-pushed the issue/105861 branch from 94cfb0a to b616db7 Compare October 28, 2021 19:25

rezakrimi marked this pull request as ready for review October 28, 2021 21:19

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2021

alculquicondor reviewed Oct 29, 2021

View reviewed changes

pkg/scheduler/metrics/metrics.go Outdated Show resolved Hide resolved

k8s-ci-robot assigned alculquicondor Oct 29, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021

rezakrimi mentioned this pull request Oct 29, 2021

Proposed graduation of scheduler metrics from alpha to stable #105861

Closed

logicalhan reviewed Nov 1, 2021

View reviewed changes

oomichi reviewed Nov 2, 2021

View reviewed changes

pkg/scheduler/metrics/metrics.go Outdated Show resolved Hide resolved

rezakrimi force-pushed the issue/105861 branch from d0ebc40 to 197283d Compare November 3, 2021 14:44

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2021

alculquicondor reviewed Nov 3, 2021

View reviewed changes

pkg/scheduler/metrics/metrics.go Outdated Show resolved Hide resolved

issue#105861: making scheduler metrics stable

bb15f02

rezakrimi force-pushed the issue/105861 branch from 197283d to bb15f02 Compare November 3, 2021 15:35

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 4, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2021

logicalhan approved these changes Nov 4, 2021

View reviewed changes

k8s-ci-robot assigned logicalhan Nov 4, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021

k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 4, 2021

k8s-ci-robot merged commit c270603 into kubernetes:master Nov 4, 2021

k8s-ci-robot added this to the v1.23 milestone Nov 4, 2021

alculquicondor mentioned this pull request Apr 19, 2022

Replace scheduler_e2e_scheduling_duration_seconds with scheduler_scheduling_attempt_duration_seconds in scheduler_perf #109546

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make some scheduler metrics stable #105941

Make some scheduler metrics stable #105941

rezakrimi commented Oct 27, 2021 •

edited

k8s-ci-robot commented Oct 27, 2021

k8s-ci-robot commented Oct 27, 2021

alculquicondor commented Oct 27, 2021

alculquicondor commented Oct 27, 2021

rezakrimi commented Oct 28, 2021

rezakrimi commented Oct 28, 2021

alculquicondor left a comment

rezakrimi commented Oct 29, 2021

logicalhan Nov 1, 2021

alculquicondor Nov 1, 2021

alculquicondor Nov 1, 2021 •

edited

rezakrimi Nov 1, 2021

dgrisonnet Nov 4, 2021

logicalhan Nov 4, 2021

oomichi left a comment

alculquicondor commented Nov 4, 2021

alculquicondor commented Nov 4, 2021

rezakrimi commented Nov 4, 2021

alculquicondor commented Nov 4, 2021

logicalhan left a comment

logicalhan Nov 4, 2021

k8s-ci-robot commented Nov 4, 2021

dashpole commented Nov 4, 2021

alculquicondor commented Apr 19, 2022

Make some scheduler metrics stable #105941

Make some scheduler metrics stable #105941

Conversation

rezakrimi commented Oct 27, 2021 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

k8s-ci-robot commented Oct 27, 2021

k8s-ci-robot commented Oct 27, 2021

alculquicondor commented Oct 27, 2021

alculquicondor commented Oct 27, 2021

rezakrimi commented Oct 28, 2021

rezakrimi commented Oct 28, 2021

alculquicondor left a comment

Choose a reason for hiding this comment

rezakrimi commented Oct 29, 2021

logicalhan Nov 1, 2021

Choose a reason for hiding this comment

alculquicondor Nov 1, 2021

Choose a reason for hiding this comment

alculquicondor Nov 1, 2021 • edited

Choose a reason for hiding this comment

rezakrimi Nov 1, 2021

Choose a reason for hiding this comment

dgrisonnet Nov 4, 2021

Choose a reason for hiding this comment

logicalhan Nov 4, 2021

Choose a reason for hiding this comment

oomichi left a comment

Choose a reason for hiding this comment

alculquicondor commented Nov 4, 2021

alculquicondor commented Nov 4, 2021

rezakrimi commented Nov 4, 2021

alculquicondor commented Nov 4, 2021

logicalhan left a comment

Choose a reason for hiding this comment

logicalhan Nov 4, 2021

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 4, 2021

dashpole commented Nov 4, 2021

alculquicondor commented Apr 19, 2022

rezakrimi commented Oct 27, 2021 •

edited

alculquicondor Nov 1, 2021 •

edited