Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #107764: wrap error from RunCordonOrUncordon #107938

Merged
merged 1 commit into from Mar 3, 2022
Merged

Automated cherry pick of #107764: wrap error from RunCordonOrUncordon #107938

merged 1 commit into from Mar 3, 2022

Conversation

heybronson
Copy link
Contributor

@heybronson heybronson commented Feb 3, 2022 •
edited

Cherry pick of #107764 on release-1.23.

#107764: wrap error from RunCordonOrUncordon

For details on the cherry pick process, see the cherry pick requests page.

Fixes error handling in a kubectl method used in downstream packages.

/sig cli
/kind bug

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Feb 3, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 3, 2022
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 3, 2022
@dims
Copy link
Member

dims commented Feb 11, 2022

This PR has needs a kind/ label. Please pick one from https://github.com/kubernetes/kubernetes/labels?q=kind and apply it. Please see https://prow.k8s.io/command-help on how to use the bot to apply labels

@olemarkus
Copy link
Member

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 13, 2022
@heybronson
Copy link
Contributor Author

/retest

rikatz
rikatz approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@rikatz rikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@heybronson
Copy link
Contributor Author

@rikatz can this get an approval?

@rikatz
Copy link
Contributor

rikatz commented Mar 1, 2022

/assign @eddiezane @soltysh

For the approval of this cherrypick :)

@eddiezane
Copy link
Member

The scope and risk of this cherry pick is extremely low and solves an issue for an org project.

/approve

/assign @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@cpanato
Copy link
Member

cpanato commented Mar 2, 2022

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 2, 2022
@cpanato
Copy link
Member

cpanato commented Mar 2, 2022

@heybronson @eddiezane we need this CP only for 1.23? i guess we can apply the same for 1.22/1.21

@heybronson
Copy link
Contributor Author

@cpanato Ideally we'd apply the same to 1.22. Kops is getting ready for the 1.23 release which is why I'm prioritizing this though.

saschagrunert
saschagrunert approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@heybronson please proceed with the cherry picks for the other branches as well

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddiezane, heybronson, rikatz, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit db12cf2 into kubernetes:release-1.23 Mar 3, 2022
@heybronson heybronson deleted the automated-cherry-pick-of-#107764-upstream-release-1.23 branch March 4, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@rikatz rikatz rikatz approved these changes

@seans3 seans3 Awaiting requested review from seans3

Assignees

@soltysh soltysh

@saschagrunert saschagrunert

@eddiezane eddiezane

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@heybronson @dims @olemarkus @rikatz @eddiezane @cpanato @k8s-ci-robot @saschagrunert @soltysh