Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show labels information when kubectl describe ingress #103894

Merged
merged 1 commit into from Aug 5, 2021
Merged

Show labels information when kubectl describe ingress #103894

merged 1 commit into from Aug 5, 2021

Conversation

kabab
Copy link
Contributor

@kabab kabab commented Jul 24, 2021 •
edited

What type of PR is this?

/king bug

What this PR does / why we need it:

display information about labels when kubectl describe ingress

Which issue(s) this PR fixes:

Fixes #103808

Display Labels when kubectl describe ingress

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 24, 2021
@k8s-ci-robot
Copy link
Contributor

@kabab: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 24, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @kabab!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @kabab. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2021
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 24, 2021
@kabab
Copy link
Contributor Author

kabab commented Jul 24, 2021

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 24, 2021
@rikatz
Copy link
Contributor

rikatz commented Jul 26, 2021

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2021
@rikatz
Copy link
Contributor

rikatz commented Jul 26, 2021

/remove-kind bug
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jul 26, 2021
@kabab
Copy link
Contributor Author

kabab commented Jul 26, 2021

/retest

brianpursley
brianpursley suggested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@brianpursley brianpursley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a unit test for ingress with labels, or change one of the existing to include labels?

@kabab kabab force-pushed the add-labels-to-ingress-describe branch from 399f940 to 1ef8334 Compare July 26, 2021 16:32
@kabab kabab force-pushed the add-labels-to-ingress-describe branch from 1ef8334 to 2ad2bc6 Compare July 26, 2021 18:08
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2021
@kabab
Copy link
Contributor Author

kabab commented Jul 26, 2021

/retest

1 similar comment
@kabab
Copy link
Contributor Author

kabab commented Jul 26, 2021

/retest

@kabab
Copy link
Contributor Author

kabab commented Jul 26, 2021

@brianpursley I've updated an existing test to include Labels, thanks

@rikatz
Copy link
Contributor

rikatz commented Jul 27, 2021

/priority backlog
@brianpursley from my side lgtm :) (also the tests!)

/lgtm

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 27, 2021
@kabab kabab requested a review from brianpursley July 30, 2021 13:42
@kabab
Copy link
Contributor Author

kabab commented Jul 30, 2021

/assign @monopole

@eddiezane
Copy link
Member

Do we want to add annotations as well? Looks like a mixed bag of what resource outputs what.

@kabab
Copy link
Contributor Author

kabab commented Jul 30, 2021

@eddiezane annotations already exist I think.

@eddiezane
Copy link
Member

@eddiezane annotations already exist I think.

You're right! It's further down.

Thanks for the PR!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianpursley, eddiezane, kabab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2021
@dims
Copy link
Member

dims commented Aug 5, 2021

/ok-to-test

@kabab
Copy link
Contributor Author

kabab commented Aug 5, 2021

/retest

1 similar comment
@kabab
Copy link
Contributor Author

kabab commented Aug 5, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6a7a527 into kubernetes:master Aug 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley brianpursley approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@monopole monopole

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

When kubectl describe ingress, there is no information about labels
7 participants
@kabab @k8s-ci-robot @rikatz @eddiezane @dims @brianpursley @monopole