Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use json stdlib for pretty-printer encoding #105466

Merged
merged 3 commits into from Oct 5, 2021
Merged

Use json stdlib for pretty-printer encoding #105466

merged 3 commits into from Oct 5, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 4, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

json-iterator indented encoding was not stdlib-compatible for objects with custom MarshalJSON implementations.

This PR switches to use the json stdlib for pretty-printing json encoding as preparation for moving off of json-iterator.

Hoisted from #105030 for early review/merge

Special notes for your reviewer:

Does this PR introduce a user-facing change?

apimachinery: pretty-printed json and yaml output is now indented consistently

/cc @deads2k
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
@liggitt
Copy link
Member Author

liggitt commented Oct 4, 2021

/retest

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2021
@liggitt
Copy link
Member Author

liggitt commented Oct 5, 2021

/retest

@liggitt
Copy link
Member Author

liggitt commented Oct 5, 2021

/priority important-longterm
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 5, 2021
@liggitt liggitt added this to the v1.23 milestone Oct 5, 2021
@deads2k
Copy link
Contributor

deads2k commented Oct 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
@liggitt liggitt mentioned this pull request Oct 5, 2021
Merged
4 tasks
@k8s-ci-robot k8s-ci-robot merged commit 7cce7ee into kubernetes:master Oct 5, 2021
@liggitt liggitt deleted the json-stdlib-pretty branch October 5, 2021 15:40
@luxas luxas mentioned this pull request Oct 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @k8s-triage-robot @deads2k