Fix: ignore not a VMSS error for VMAS nodes in reconcileBackendPools #103997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
feiskyer
reviewed
Jul 29, 2021
nilo19
force-pushed
the
bug/cherry-pick-551
branch
from
7c9d427
to
c406f2e
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
/assign @cheftako |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/milestone v1.22 |
|
/test pull-kubernetes-integration |
|
@nilo19 , I see that you created cherry-pick PR for release-1.21. You have to create a cherry-pick PR for release-1.22 as well. Can you take care? |
This was referenced Aug 2, 2021
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 2, 2021
…97-upstream-release-1.20 Automated cherry pick of #103997: Fix: ignore not a VMSS error for VMAS nodes in
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 2, 2021
…97-upstream-release-1.22 Automated cherry pick of #103997: Fix: ignore not a VMSS error for VMAS nodes in
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 2, 2021
…97-upstream-release-1.21 Automated cherry pick of #103997: Fix: ignore not a VMSS error for VMAS nodes in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix: ignore not a VMSS error for VMAS nodes in reconcileBackendPools
Which issue(s) this PR fixes:
Fixes kubernetes-sigs/cloud-provider-azure#706
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/triage accepted
/kind bug
/area provider/azure
/sig cloud-provider
/priority critical-urgent
cc @feiskyer @CecileRobertMichon