Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang used in etcd image to 1.16.3 #104301

Merged
merged 1 commit into from Aug 12, 2021
Merged

Update golang used in etcd image to 1.16.3 #104301

merged 1 commit into from Aug 12, 2021

Conversation

serathius
Copy link
Contributor

@serathius serathius commented Aug 11, 2021 •
edited

Fixes #104297
/kind bug

Update Go used to build migrate script in etcd image to v1.16.7

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 11, 2021
@serathius
Copy link
Contributor Author

/area release-eng

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 11, 2021
@serathius
Copy link
Contributor Author

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Aug 11, 2021
@dims
Copy link
Member

dims commented Aug 11, 2021

@serathius wanna update dependencies.yaml too? https://github.com/kubernetes/kubernetes/blob/master/build/dependencies.yaml#L86-L96

@CaoDonghui123
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
@serathius
Copy link
Contributor Author

Done

@serathius
Copy link
Contributor Author

/assign @fejta @jpbetz

@fejta
Copy link
Contributor

fejta commented Aug 12, 2021

/approve

1 similar comment
@jpbetz
Copy link
Contributor

jpbetz commented Aug 12, 2021

/approve

@jpbetz
Copy link
Contributor

jpbetz commented Aug 12, 2021

/priority important-longterm
/triage accepted

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, jpbetz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
@jpbetz
Copy link
Contributor

jpbetz commented Aug 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1ebc6bf into kubernetes:master Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 12, 2021
@spiffxp spiffxp mentioned this pull request Sep 27, 2021
Closed
kl52752 pushed a commit to kl52752/kubernetes that referenced this pull request Dec 23, 2022
@JacobX33 @kl52752
Bump golang version to 1.16 in gke/cluster/images/etcd
46c8a4d 
This is internal adaptation/cherrypick of kubernetes#104301.

b/196328956

Change-Id: I5945fb6982723175493aeb84c7e4cf8137f529ea
aojea pushed a commit to aojea/kubernetes that referenced this pull request Jun 14, 2023
@jingyih @aojea
etcd: image and manifest changes
dd28ece 
Add backup-before-start to etcd image

The script makes a copy of the etcd data file. It includes unix
timestamp as part of the filename to do rate limiting. It creates at
most 3 copies to avoid excessive usage of disk space.

This is part of go/gke-backup-before-upgrade

I047d6bbf6dfd52fdee870083b4a7104b3cf66a2d

Fixes: b/145255982

I65875f37fbc834cf87930580534ae21dd905e0ae

Disable rollback in migrate-if-needed

Fix: b/157964586

I4142805f5c7ea3fcb92b6ba1fd6f898a5d8f9543

Reimplement backup-before-start script in golang

Icaec7dffed6dea2361aecac290683d5fe8595196

Disable rollback case for etcd migrator

I6885957a5fc9205cad612265e7f81aa1826624fc

Run backup-before-start.sh before starting etcd, Migrate etcd-image manifest run logic to etcd-main.sh

Run backup-before-start.sh as startup script of etcd pod. The script is
added in
https://gke-internal-review.googlesource.com/c/kubernetes/+/98628

This is part of go/gke-backup-before-upgrade

Original Change-Id: I8841ea1ff9ba3bb2661f63366a01a0cf70d963df

Migrate etcd-image manifest run logic to etcd-main.sh

1. Improves the logging to make the phase and complition code explicit.
2. Performs graceful shutdown sequence: SIGTERM, 20s, SIGQUIT (that dumps routines)
3. Avoid template variable expansion {{ suffix }} within the command.
Instead all the parameters are transferred through env variables. It
allows for easy change of command without risking messing up 'values'
when playing on master machine directly.

Original Change-Id: I9a22197c58c98df93b38eb88375feb59fa7c10ee

Original Change-Id: I5cd4820c0d3a3bc806b43afa74a3cc38c38b537d

Change-Id: Iae3da6df4202001aab67ab4b413a7780dd8bc556

Change-Id: I4252979d06a1f594ecd8e2a6e5f242f2f8580fc9

Add backup restore logic for etcd

b/194276834

Change-Id: Ic08ec47988d07881edffb39d6c33963835198506

Change-Id: I01f42a3ca3a1922a339e008c96f7ccc1475114ec

Remove set errexit from etcd manifest, context omg/34631

Bug: 189310801
Bug: 195005070
Change-Id: I2d3359ad329cd858b22f606249a81a932272404a

Make etcd restore read token from file and save end status

Change-Id: Ie4a7f050e4f291c947dd76d20ef0f6a23cad066b

Implement data verification mechanism for etcd restore binary

Use etcdctl snapshot status to make sure data is not corrupted and matches pre-restore backup. Details in bug.

b/194277398

Change-Id: Ic187ecfb771e2f529bf5ea9d2e11b964f2d807f3

Add logic for checking integrity hash to etcd restore

Backups made via "backup before start" do not have this hash.

b/196354846

Change-Id: I5ee0b0d9218e74ab6810c2688334b6538be9eaf2

Bump golang version to 1.16 in gke/cluster/images/etcd

This is internal adaptation/cherrypick of kubernetes#104301.

b/196328956

Change-Id: I5945fb6982723175493aeb84c7e4cf8137f529ea

This reverts "Migrate etcd's livenessProbe to etcdctl endpoint health."
and gkcl/292591 ("Specify etcdctl version for livenessProbe")
This reverts commit 7f09d59.
This reverts commit 167d5b919f4b8d045857f9ffc9d5a25c677a851f.

Reason for revert: b/197973550

Bug: b/197973550
Change-Id: I0383612a2edf68531b6d2b1b84f5436997996afc

Write-rename version.txt

This is copy of (not merged yet) PR in OSS - kubernetes#106653
See b/179669118

Change-Id: I7f208cfc718d11e1c0ac5f5a716e5896dc47dcb4

Lazy write version.txt

This is copy of (not merged yet) PR in OSS - kubernetes#106658
See b/179669118

Change-Id: Ifc4437dd189d5abd0a809c12fc82702504b8c29c

Rename VersionFile `contains` to `equals`

https: //github.com/kubernetes/pull/106658 weren't merged when https://gke-internal-review.googlesource.com/c/kubernetes/+/369902 were merged. This commit is diff between those 2. In short: it makes OSS and internal repo aligned.
Change-Id: I18b8c81b51632ee68aff7579fc57ee92e6cac3f9

gke/cluster: fix etcd to use semver/v4

Adapt to kubernetes#108629

Change-Id: I90d9a6d6725548960ea44af99155105cdf62f3a7

Change-Id: I92dd57e6aee95b50fa440cc8858264fed46d7a0d
serathius pushed a commit to serathius/kubernetes that referenced this pull request Mar 14, 2024
@jingyih
etcd: image and manifest changes
6d1ddd3 
Add backup-before-start to etcd image

The script makes a copy of the etcd data file. It includes unix
timestamp as part of the filename to do rate limiting. It creates at
most 3 copies to avoid excessive usage of disk space.

This is part of go/gke-backup-before-upgrade

I047d6bbf6dfd52fdee870083b4a7104b3cf66a2d

Fixes: b/145255982

I65875f37fbc834cf87930580534ae21dd905e0ae

Disable rollback in migrate-if-needed

Fix: b/157964586

I4142805f5c7ea3fcb92b6ba1fd6f898a5d8f9543

Reimplement backup-before-start script in golang

Icaec7dffed6dea2361aecac290683d5fe8595196

Disable rollback case for etcd migrator

I6885957a5fc9205cad612265e7f81aa1826624fc

Run backup-before-start.sh before starting etcd, Migrate etcd-image manifest run logic to etcd-main.sh

Run backup-before-start.sh as startup script of etcd pod. The script is
added in
https://gke-internal-review.googlesource.com/c/kubernetes/+/98628

This is part of go/gke-backup-before-upgrade

Original Change-Id: I8841ea1ff9ba3bb2661f63366a01a0cf70d963df

Migrate etcd-image manifest run logic to etcd-main.sh

1. Improves the logging to make the phase and complition code explicit.
2. Performs graceful shutdown sequence: SIGTERM, 20s, SIGQUIT (that dumps routines)
3. Avoid template variable expansion {{ suffix }} within the command.
Instead all the parameters are transferred through env variables. It
allows for easy change of command without risking messing up 'values'
when playing on master machine directly.

Original Change-Id: I9a22197c58c98df93b38eb88375feb59fa7c10ee

Original Change-Id: I5cd4820c0d3a3bc806b43afa74a3cc38c38b537d

Change-Id: Iae3da6df4202001aab67ab4b413a7780dd8bc556

Change-Id: I4252979d06a1f594ecd8e2a6e5f242f2f8580fc9

Add backup restore logic for etcd

b/194276834

Change-Id: Ic08ec47988d07881edffb39d6c33963835198506

Change-Id: I01f42a3ca3a1922a339e008c96f7ccc1475114ec

Remove set errexit from etcd manifest, context omg/34631

Bug: 189310801
Bug: 195005070
Change-Id: I2d3359ad329cd858b22f606249a81a932272404a

Make etcd restore read token from file and save end status

Change-Id: Ie4a7f050e4f291c947dd76d20ef0f6a23cad066b

Implement data verification mechanism for etcd restore binary

Use etcdctl snapshot status to make sure data is not corrupted and matches pre-restore backup. Details in bug.

b/194277398

Change-Id: Ic187ecfb771e2f529bf5ea9d2e11b964f2d807f3

Add logic for checking integrity hash to etcd restore

Backups made via "backup before start" do not have this hash.

b/196354846

Change-Id: I5ee0b0d9218e74ab6810c2688334b6538be9eaf2

Bump golang version to 1.16 in gke/cluster/images/etcd

This is internal adaptation/cherrypick of kubernetes#104301.

b/196328956

Change-Id: I5945fb6982723175493aeb84c7e4cf8137f529ea

This reverts "Migrate etcd's livenessProbe to etcdctl endpoint health."
and gkcl/292591 ("Specify etcdctl version for livenessProbe")
This reverts commit 7f09d59.
This reverts commit 167d5b919f4b8d045857f9ffc9d5a25c677a851f.

Reason for revert: b/197973550

Bug: b/197973550
Change-Id: I0383612a2edf68531b6d2b1b84f5436997996afc

Write-rename version.txt

This is copy of (not merged yet) PR in OSS - kubernetes#106653
See b/179669118

Change-Id: I7f208cfc718d11e1c0ac5f5a716e5896dc47dcb4

Lazy write version.txt

This is copy of (not merged yet) PR in OSS - kubernetes#106658
See b/179669118

Change-Id: Ifc4437dd189d5abd0a809c12fc82702504b8c29c

Rename VersionFile `contains` to `equals`

https: //github.com/kubernetes/pull/106658 weren't merged when https://gke-internal-review.googlesource.com/c/kubernetes/+/369902 were merged. This commit is diff between those 2. In short: it makes OSS and internal repo aligned.
Change-Id: I18b8c81b51632ee68aff7579fc57ee92e6cac3f9

gke/cluster: fix etcd to use semver/v4

Adapt to kubernetes#108629

Change-Id: I90d9a6d6725548960ea44af99155105cdf62f3a7

Change-Id: I92dd57e6aee95b50fa440cc8858264fed46d7a0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

Assignees

@jpbetz jpbetz

@fejta fejta

@CaoDonghui123 CaoDonghui123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

cluster/images/etcd uses old golang version and does not build
6 participants
@serathius @dims @CaoDonghui123 @fejta @jpbetz @k8s-ci-robot