Reduce the number of expensive calls in the Windows stats queries for dockershim #104287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
unrelated flake #106326 |
|
/assign @dchen1107 |
marosset
moved this from In Progress (v1.23)
to Reviewed - Needs Approval From Other SIGs
in SIG-Windows
|
/assign @mrunalp |
|
Hi @jsturtevant, |
We would to have this merged for 1.23. We just need final approval from area owners. |
mrunalp
approved these changes
Nov 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
SIG-Windows
automation
moved this from Reviewed - Needs Approval From Other SIGs
to Done (v1.23)
Nov 16, 2021
This was referenced Nov 17, 2021
|
/priority critical-urgent |
|
/remove-priority backlog |
k8s-ci-robot
added
priority/critical-urgent
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 1, 2021
…#104287-upstream-release-1.20 Automated cherry pick of #104287: Reduce calls to docker from dockershim for stats
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 1, 2021
…#104287-upstream-release-1.22 Automated cherry pick of #104287: Reduce calls to docker from dockershim for stats
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 1, 2021
…#104287-upstream-release-1.21 Automated cherry pick of #104287: Reduce calls to docker from dockershim for stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This improves the response time and minimizes the calls to the system stats which reduces overall cpu for kubelet. This is done by passing the container object, which has the information required, instead of querying for it on every container via the dockerservice. It also caches some information like the runtime info so it is not queried on every container.
Dockershim create a new namepiped instance to docker every call causing reads and higher cpu usage. (Containerd re-uses the same namedpipe instance so doesn't see the same cpu spike).
Which issue(s) this PR fixes:
Fixes #104283
Special notes for your reviewer:
I initially included the commits from #105744 but moved it to a separate PR. That PR also improves the overall CPU used here but not opening and list all the containers twice.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: