Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete stale UDP conntrack entries for loadbalancer IPs #104009

Merged
merged 1 commit into from Aug 5, 2021
Merged

delete stale UDP conntrack entries for loadbalancer IPs #104009

merged 1 commit into from Aug 5, 2021

Conversation

aojea
Copy link
Member

@aojea aojea commented Jul 29, 2021

/kind bug

What this PR does / why we need it:

From the long saga of UDP conntrack stale entries breaking services, we have a new chapter because I forget to consider the lb ingress IPs

kube-proxy: delete stale conntrack UDP entries for loadbalancer ingress IP.

Fixes: #103857

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 29, 2021
@aojea aojea mentioned this pull request Jul 29, 2021
Closed
@aojea
Copy link
Member Author

aojea commented Jul 29, 2021

/assign @thockin @danwinship

@aojea
Copy link
Member Author

aojea commented Jul 29, 2021

/sig network

aojea
aojea commented Jul 29, 2021
View reviewed changes
pkg/proxy/iptables/proxier_test.go
sort.Strings(expectedCommands)
sort.Strings(actualCommands)

if !reflect.DeepEqual(expectedCommands, actualCommands) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is flake free

$ go test -timeout 100s -run ^TestProxierDeleteNodePortStaleUDP$ k8s.io/kubernetes/pkg/proxy/iptables -c
$ stress ./iptables.test 
105 runs so far, 0 failures

@dkulchinsky
Copy link

@aojea thank for the fix! 😄

Do you think this is important enough to get ported into v1.20 🙏🏼

@aojea
Copy link
Member Author

aojea commented Jul 29, 2021

@aojea thank for the fix!

Do you think this is important enough to get ported into v1.20 🙏🏼

yeah, I think it qualifies
/retest

@aojea
Copy link
Member Author

aojea commented Jul 30, 2021

/sig network

@danwinship
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
@dims
Copy link
Member

dims commented Aug 4, 2021

/sig network

@dims dims removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 4, 2021
This was referenced Aug 5, 2021
Merged
Merged
@dims
Copy link
Member

dims commented Aug 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 5, 2021
@pacoxu
Copy link
Member

pacoxu commented Aug 5, 2021

/retest

@aojea
Copy link
Member Author

aojea commented Aug 5, 2021 •
edited

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 2c1c1b7 into kubernetes:master Aug 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 5, 2021
@dkulchinsky
Copy link

@aojea happy to see this passing and getting merged! I see two cherry picks linked here for 1.22 and 1.21, is there any chance to see a 1.20 cherry pick as well?

@aojea
Copy link
Member Author

aojea commented Aug 5, 2021 •
edited

@aojea happy to see this passing and getting merged! I see two cherry picks linked here for 1.22 and 1.21, is there any chance to see a 1.20 cherry pick as well?

#104152

it is not a clean backport, I need to figure out the issues

@dkulchinsky
Copy link

@aojea happy to see this passing and getting merged! I see two cherry picks linked here for 1.22 and 1.21, is there any chance to see a 1.20 cherry pick as well?

#104152

it is not a clean backport, I need to figure out the issues

Wonderful! Sorry, should have looked better for it myself.

@aojea
Copy link
Member Author

aojea commented Aug 5, 2021

@aojea happy to see this passing and getting merged! I see two cherry picks linked here for 1.22 and 1.21, is there any chance to see a 1.20 cherry pick as well?

#104152
it is not a clean backport, I need to figure out the issues

Wonderful! Sorry, should have looked better for it myself.

is not your fault, I had to cherry pick it from a cherry pick, that is why it didn't show up here,

@cpanato
Copy link
Member

cpanato commented Aug 16, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 16, 2021
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2021
@k8s-ci-robot
Merge pull request #104149 from aojea/automated-cherry-pick-of-#10400…
807ed8e 
…9-upstream-release-1.22

Automated cherry pick of #104009: delete stale UDP conntrack entries for loadbalancer IPs
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2021
@k8s-ci-robot
Merge pull request #104151 from aojea/automated-cherry-pick-of-#10400…
d0d5554 
…9-upstream-release-1.21

Automated cherry pick of #104009: delete stale UDP conntrack entries for loadbalancer IPs
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 15, 2022
Closed
@aojea aojea mentioned this pull request Oct 21, 2022
Closed
@aojea aojea mentioned this pull request Jun 26, 2023
Closed
@raymondchen625 raymondchen625 mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@danwinship danwinship

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
8 participants
@aojea @k8s-ci-robot @dkulchinsky @danwinship @dims @pacoxu @cpanato @thockin