fix: skip instance not found when decoupling vmss from lb #105666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
lgtm
|
/assign @cheftako @andrewsykim @cheftako @andrewsykim could you help to approve this fix? |
nilo19
force-pushed
the
fix/cherry-pick-842
branch
from
1e65937
to
db64d25
Compare
k8s-ci-robot
added
size/S
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
nilo19
force-pushed
the
fix/cherry-pick-842
branch
from
db64d25
to
b0cdc77
Compare
k8s-ci-robot
added
size/M
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
ping @cheftako @andrewsykim could you help to approve this fix? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
/test pull-kubernetes-node-e2e-containerd |
This was referenced Oct 22, 2021
Merged
Merged
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 9, 2021
…66-upstream-release-1.20 Automated cherry pick of #105666: fix: skip instance not found when decoupling vmss from lb
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 10, 2021
…66-upstream-release-1.22 Automated cherry pick of #105666: fix: skip instance not found when decoupling vmss from lb
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 10, 2021
…66-upstream-release-1.21 Automated cherry pick of #105666: fix: skip instance not found when decoupling vmss from lb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Ref: kubernetes-sigs/cloud-provider-azure#842
fix: skip instance not found when decoupling vmss from lb
Which issue(s) this PR fixes:
Fixes kubernetes-sigs/cloud-provider-azure#787
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/area provider/azure
/sig cloud-provider
/triage accepted
/priority critical-urgent
cc @feiskyer