fix: remove VMSS and VMSS instances from SLB backend pool only when necessary #105839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
nilo19
force-pushed
the
bug/cherry-pick-856
branch
2 times, most recently
from
d6ab4aa
to
6a61d8b
Compare
nilo19
force-pushed
the
bug/cherry-pick-856
branch
from
6a61d8b
to
81eb757
Compare
|
/retest |
k8s-ci-robot
added
the
lgtm
|
/assign @cheftako @andrewsykim |
|
kindly ping @cheftako @andrewsykim for approval |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Nov 2, 2021
Closed
Merged
Merged
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 12, 2022
…39-upstream-release-1.20 Automated cherry pick of #105839: fix: remove VMSS and VMSS instances from SLB backend pool
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 12, 2022
…39-upstream-release-1.21 Automated cherry pick of #105839: fix: remove VMSS and VMSS instances from SLB backend pool
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 12, 2022
…39-upstream-release-1.22 Automated cherry pick of #105839: fix: remove VMSS and VMSS instances from SLB backend pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: remove VMSS and VMSS instances from SLB backend pool only when necessary
Ref: kubernetes-sigs/cloud-provider-azure#856
Which issue(s) this PR fixes:
Fixes kubernetes-sigs/cloud-provider-azure#851
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/triage accepted
/priority critical-urgent
/sig cloud-provider
/area provider/azure
cc @feiskyer