New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote min ready sec sts beta #104045
Promote min ready sec sts beta #104045
Conversation
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/sig apps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase and this is ready to go
194d9e1
to
12353e9
Compare
/remove-sig api-machinery |
Is there an STS minReadySeconds e2e? |
API changes are reviewed and approved. |
@smarterclayton - Here is the test which exercises sts e2e |
/approve Changes /lgtm based on other comments and review |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atiratree, ravisantoshgudimetla, smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
All integration tests passed, I think it's an issue with clean-up code. /retest |
@@ -1420,7 +1420,8 @@ | |||
} | |||
}, | |||
"required": [ | |||
"replicas" | |||
"replicas", | |||
"availableReplicas" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding a new field marked as required is not backwards compatible... this should be marked optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be fixed reverted in the next patch version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, @ravisantoshgudimetla is opening a PR and will pick it back
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: