prevents garbage collection from removing pinned images #103299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
needs-priority
|
Is there a KEP or issue tracking this? |
wgahnagl
force-pushed
the
addPinned
branch
2 times, most recently
from
b51f03b
to
9c683d1
Compare
|
this was combined with CRI beta kep: kubernetes/enhancements#2694 |
|
/retest |
k8s-ci-robot
added
size/XXL
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
endocrimes
reviewed
Jul 12, 2021
endocrimes
reviewed
Jul 13, 2021
| @@ -193,6 +193,25 @@ func TestDeleteUnusedImagesExemptSandboxImage(t *testing.T) { | |||
| require.NoError(t, err) | |||
| } | |||
|
|
|||
| func TestDeletePinnedImage(t *testing.T) { | |||
There was a problem hiding this comment.
I'd recommend adding cases for:
- List with no pinned images
- List with only pinned images
- List with mixed images
For the CRI implementation to be able to indicate to the Kubelet that an image should not be garbage collected. Signed-off-by: Peter Hunt <pehunt@redhat.com>
k8s-ci-robot
added
cncf-cla: yes
|
@pacoxu sorry this took so long! Ptal! |
endocrimes
reviewed
Nov 3, 2021
| @@ -206,6 +206,105 @@ func TestDeleteUnusedImagesExemptSandboxImage(t *testing.T) { | |||
| require.NoError(t, err) | |||
| } | |||
|
|
|||
| func TestDeletePinnedImage(t *testing.T) { | |||
| mockCtrl := gomock.NewController(t) | |||
| defer mockCtrl.Finish() | |||
There was a problem hiding this comment.
no need to call Finish when passing a testing.T into NewController as of go1.14 (https://pkg.go.dev/github.com/golang/mock/gomock#Controller.Finish)
Suggested change
| defer mockCtrl.Finish() |
| require.NoError(t, err) | ||
| assert.EqualValues(0, spaceFreed) | ||
| assert.Len(fakeRuntime.ImageList, 2) | ||
| } |
k8s-ci-robot
added
the
lgtm
mrunalp
approved these changes
Nov 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, wgahnagl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
prevents garbage collection from removing pinned images
Which issue(s) this PR fixes:
#101808
implements this
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: