Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

component-base: test and fix JSON output for KObj #104877

Merged
merged 2 commits into from Oct 22, 2021
Merged

component-base: test and fix JSON output for KObj #104877

merged 2 commits into from Oct 22, 2021

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Sep 9, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

KObj wasn't get logged as struct when using JSON output.

Does this PR introduce a user-facing change?

Kubernetes object references (= name + namespace) were not logged as struct when using JSON as log output format.

/cc @serathius @thockin

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 9, 2021
This was referenced Sep 9, 2021
Closed
Closed
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 9, 2021
@serathius
Copy link
Contributor

Sad that we missed this, I think I remember noticing this at some point, but when final implementation came we didn't have tests. We should definetly fix it for 1.23, @pohly can you file a issue to address this. We should track it in the Structured Logging KEP.

@pohly
Copy link
Contributor Author

pohly commented Sep 9, 2021

/hold

Let's use this PR to include a fix, if there is one.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021
@fedebongio
Copy link
Contributor

/assign @serathius
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 9, 2021
@pohly pohly mentioned this pull request Sep 10, 2021
Closed
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2021
@serathius
Copy link
Contributor

/lgtm
/approve

@pohly pohly changed the title WIP: component-base: test json output for KObj WIP: component-base: test and fix JSON output for KObj Oct 20, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 20, 2021
@pohly
Copy link
Contributor Author

pohly commented Oct 20, 2021

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 20, 2021
@pohly pohly mentioned this pull request Oct 20, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 22, 2021
@pohly pohly changed the title WIP: component-base: test and fix JSON output for KObj component-base: test and fix JSON output for KObj Oct 22, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2021
@dims
Copy link
Member

dims commented Oct 22, 2021

/assign @liggitt

@pohly
klog 2.30.0, logr 1.2.0, zapr 1.2.0
169e8b6 
The new releases fix logging of KObj in JSON output: klog implements the new
logr.Marshaler interface and zapr uses it instead of Stringer when logging the
ObjectRef created by KObj.
@pohly
component-base: test json output for KObj and KObjs
e36d54c 
Thanks to the new klog, logr and zapr releases, ObjectRef is now
logged as struct in JSON output.
@liggitt
Copy link
Member

liggitt commented Oct 22, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2021
@dims
Copy link
Member

dims commented Oct 22, 2021

/approve
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, pohly, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a5cd438 into kubernetes:master Oct 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 22, 2021
SIG Auth Old automation moved this from Needs Triage to Closed / Done Oct 22, 2021
JaneLiuL pushed a commit to JaneLiuL/kubernetes that referenced this pull request Oct 25, 2021
@k8s-ci-robot @JaneLiuL
Merge pull request kubernetes#104877 from pohly/json-kobj
cd9d697 
component-base: test and fix JSON output for KObj
@randomvariable randomvariable mentioned this pull request Oct 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzhiquan yuzhiquan yuzhiquan left review comments

@serathius serathius serathius left review comments

@k8s-ci-robot k8s-ci-robot k8s-ci-robot left review comments

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

@liggitt liggitt

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
SIG Auth
Archived in project
SIG Auth Old
Closed / Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pohly @serathius @fedebongio @shiva1333 @dims @liggitt @k8s-ci-robot @yuzhiquan