Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful Node Shutdown Based On Pod Priority #102915

Merged
merged 5 commits into from Nov 18, 2021
Merged

Graceful Node Shutdown Based On Pod Priority #102915

merged 5 commits into from Nov 18, 2021

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Jun 16, 2021 •
edited

What type of PR is this?

/kind feature
/sig node

What this PR does / why we need it:

KEP: kubernetes/enhancements#2712
https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2712-pod-priority-based-graceful-node-shutdown

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support pod priority based node graceful shutdown

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2712-pod-priority-based-graceful-node-shutdown

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 16, 2021
@wzshiming wzshiming mentioned this pull request Jun 16, 2021
Merged
@wzshiming wzshiming changed the title Graceful shutdown based on Pod priority [WIP] Graceful shutdown based on Pod priority Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2021
@wzshiming wzshiming force-pushed the feat/graceful-shutdown-based-on-pod-priority branch from afacde2 to 426f724 Compare June 16, 2021 09:47
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jun 16, 2021
@wzshiming wzshiming force-pushed the feat/graceful-shutdown-based-on-pod-priority branch 2 times, most recently from 5c72795 to 0299ddc Compare June 16, 2021 11:35
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 16, 2021
@wzshiming wzshiming changed the title [WIP] Graceful shutdown based on Pod priority [WIP] Pod Priority Based Node Graceful Shutdown Jun 16, 2021
@wzshiming wzshiming force-pushed the feat/graceful-shutdown-based-on-pod-priority branch 2 times, most recently from b07a2fc to 9997153 Compare June 16, 2021 12:54
@wzshiming
Copy link
Member Author

/retest

@wzshiming wzshiming changed the title [WIP] Pod Priority Based Node Graceful Shutdown Pod Priority Based Node Graceful Shutdown Jun 16, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2021
@wzshiming
Copy link
Member Author

/cc @bobbypage
/cc @mrunalp

@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Nov 16, 2021
@wzshiming wzshiming force-pushed the feat/graceful-shutdown-based-on-pod-priority branch from 0edbbea to 00df75b Compare November 17, 2021 03:35
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@wzshiming wzshiming force-pushed the feat/graceful-shutdown-based-on-pod-priority branch from 00df75b to 934d0f5 Compare November 17, 2021 03:43
@wzshiming wzshiming force-pushed the feat/graceful-shutdown-based-on-pod-priority branch from 934d0f5 to 7c656b5 Compare November 17, 2021 03:47
@wzshiming
Copy link
Member Author

@smarterclayton
Updated.

@smarterclayton
Copy link
Contributor

/approve

API is sufficient

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
@dims
Copy link
Member

dims commented Nov 17, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 17, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Nov 17, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@ehashman
Copy link
Member

Exception request was approved: https://kubernetes.slack.com/archives/C2C40FMNF/p1637091817154300?thread_ts=1637084815.149600&cid=C2C40FMNF

/milestone v1.23

@ehashman
Copy link
Member

flake #106506

/test pull-kubernetes-conformance-kind-ga-only-parallel

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 18, 2021 •
edited

@wzshiming: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-kubelet-serial 0edbbeadf406cfe3cc2c528eafa67b1a70c25a06 link false /test pull-kubernetes-node-kubelet-serial
pull-kubernetes-node-kubelet-serial-containerd 0edbbeadf406cfe3cc2c528eafa67b1a70c25a06 link false /test pull-kubernetes-node-kubelet-serial-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacoxu
Copy link
Member

pacoxu commented Nov 18, 2021

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot merged commit 91b7fb4 into kubernetes:master Nov 18, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Nov 18, 2021
@wzshiming wzshiming deleted the feat/graceful-shutdown-based-on-pod-priority branch November 18, 2021 03:28
@liggitt liggitt moved this from Assigned to API review completed, 1.23 in API Reviews Dec 13, 2021
@kwilczynski kwilczynski mentioned this pull request Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton smarterclayton left review comments

@pacoxu pacoxu pacoxu left review comments

@ehashman ehashman ehashman left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@rphillips rphillips Awaiting requested review from rphillips

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

@bobbypage bobbypage Awaiting requested review from bobbypage

Assignees

@mrunalp mrunalp

@bobbypage bobbypage

@smarterclayton smarterclayton

@ehashman ehashman

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.23
SIG Node CI/Test Board
Archive-it
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet