Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate apiserver_longrunning_guage and apiserver_registered_watchers #103793

Merged
merged 1 commit into from Aug 5, 2021
Merged

Deprecate apiserver_longrunning_guage and apiserver_registered_watchers #103793

merged 1 commit into from Aug 5, 2021

Conversation

yan-lgtm
Copy link

@yan-lgtm yan-lgtm commented Jul 20, 2021 •
edited

What type of PR is this?

Add one of the following kinds:
/kind bug

Optionally add one or more of the following kinds if applicable:
/kind deprecation

What this PR does / why we need it:

Deprecate apiserver_longrunning_gauge and apiserver_register_watchers

Which issue(s) this PR fixes:

Fixes #103441

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Deprecate apiserver_longrunning_gauge and apiserver_register_watchers in 1.23.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @yan-lgtm!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @yan-lgtm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 20, 2021
@yan-lgtm yan-lgtm mentioned this pull request Jul 20, 2021
Closed
@jyz0309 jyz0309 mentioned this pull request Jul 20, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jul 20, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2021
@fedebongio
Copy link
Contributor

/assign @logicalhan
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 20, 2021
logicalhan
logicalhan approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@logicalhan
Copy link
Member

hey, would you mind squashing your commits? there seem to be like 8 in there

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels Jul 20, 2021
logicalhan
logicalhan approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan, yan-lgtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logicalhan
Copy link
Member

Would you mind amending the release note to say that these two metrics are now deprecated?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 20, 2021
@logicalhan
Copy link
Member

/retest

@logicalhan
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 20, 2021
Deprecate apiserver_longrunning_guage and apiserver_registered_watchers
e2b6816 
Deprecate apiserver_longrunning_guage and apiserver_registered_watchers

Update

Fix name

update

Add back empty space

Update the deprecated version to 1.23
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2021
logicalhan
logicalhan reviewed Jul 20, 2021
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6442280 into kubernetes:master Aug 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 5, 2021
@yan-lgtm yan-lgtm deleted the deperate branch August 5, 2021 15:50
philipgough added a commit to philipgough/kube-prometheus that referenced this pull request Dec 16, 2021
@philipgough
jsonnet: Drop deprecated apiserver_longrunning_gauge metric
bbb82ae 
Drop deprecated metric to fix failing test.

Dropped via kubernetes/kubernetes#103793
philipgough added a commit to philipgough/kube-prometheus that referenced this pull request Dec 16, 2021
@philipgough
jsonnet: Drop deprecated apiserver_longrunning_gauge metric
7c6f9eb 
Drop deprecated metric to fix failing test.

Dropped via kubernetes/kubernetes#103793
philipgough added a commit to philipgough/kube-prometheus that referenced this pull request Dec 16, 2021
@philipgough
jsonnet: Drop deprecated apiserver_longrunning_gauge and apiserver_re…
39574e6 
…gistered_watchers metrics

Drop deprecated metric to fix failing test.

Dropped via kubernetes/kubernetes#103793
philipgough added a commit to philipgough/kube-prometheus that referenced this pull request Dec 16, 2021
@philipgough
jsonnet: Drop deprecated apiserver_longrunning_gauge and apiserver_re…
1263e1c 
…gistered_watchers metrics

Drop deprecated metric to fix failing test.

Dropped via kubernetes/kubernetes#103793
kskalski pushed a commit to kskalski/kube-prometheus that referenced this pull request Jan 23, 2022
@philipgough @kskalski
jsonnet: Drop deprecated apiserver_longrunning_gauge and apiserver_re…
9b8a448 
…gistered_watchers metrics

Drop deprecated metric to fix failing test.

Dropped via kubernetes/kubernetes#103793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@jyz0309 jyz0309 jyz0309 left review comments

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@logicalhan logicalhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Deprecate apiserver_longrunning_guage and apiserver_registered_watchers in favor of a new metric
5 participants
@yan-lgtm @k8s-ci-robot @fedebongio @logicalhan @jyz0309