New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove nodeLease feature GA #105222
remove nodeLease feature GA #105222
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @cyclinder! |
Hi @cyclinder. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
c78a6b6
to
86d6c25
Compare
/retest |
@calvin0327: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
b793f53
to
8c0acdf
Compare
/check-cla |
8c0acdf
to
639aaac
Compare
/assign @mtaufen |
@ehashman would you have time to take a look again? |
/lgtm /assign @liggitt - for API approval |
/approve /hold in case @wojtek-t wanted #105222 (comment) addressed before merge |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyclinder, liggitt, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
fa3dd3a
to
e61b901
Compare
/lgtm /hold cancel |
Shouldn't this have a small release note, to confirm that the kubelet no longer recognizes this feature gate? |
Good point - added. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
remove nodeLease feature GA
Special notes for your reviewer:
Feature gate convention has been updated since this feature gate was introduced to indicate that they are intended to be deprecated and removed after a feature becomes GA or is dropped
in v1.17 node lease has been promoted to GA,but in
https://github.com/kubernetes/blob/005dfcd09e643312d12b0b4838186c7727065c73/pkg/features/kube_features.go#L195 node lease feature still exist,so i deleted it and edit some describption info about node lease.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: