'kubectl events' command #99557
Merged
'kubectl events' command #99557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/kubectl
sig/cli
12 tasks
|
@soltysh could I ask for some feedback please on the overall approach |
This was referenced Jun 30, 2021
k8s-ci-robot
added
the
needs-rebase
|
/cc |
Borrowing code from 'kubectl describe'
Print namespace if fetching from all
To make it easier to add watch function next.
Run the list function same as before, so those events come out in order, then watch from the ResourceVersion after the last event.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Flags represents the inputs from the CLI; options are what the running command needs. This structure parallels the 'wait' command, and should be easier to write tests for. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
soltysh
reviewed
Oct 28, 2021
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
We tried to print the list first then start a watch after the last event, but sometimes the server will return "watch is too old" on that ResourceVersion. Instead, if we need to watch just start it from the beginning. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Also, if watching, don't print the headings until the first event arrives. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
bboreham
force-pushed
the
kubectl-events
branch
from
daecfb0
to
f215193
Compare
soltysh
approved these changes
Oct 29, 2021
k8s-ci-robot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bboreham, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Some ideas for further enhancements:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a new verb 'events' to
kubectlwhich addresses various deficiencies withkubectl get events.Which issue(s) this PR fixes:
kubernetes/enhancements#1440
Fixes: kubernetes/kubectl#704
Fixes: #29838
Special notes for your reviewer:
This is a very minimal version, posted to see if I'm on the right track.
In particular, it does not implement any flexibility on output formats.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Video of KubeCon talk "The Soul of a New Command: Adding ‘Events’ to kubectl"