Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate IngressClassNamespacedParams to GA #104636

Merged
merged 1 commit into from Nov 10, 2021
Merged

Graduate IngressClassNamespacedParams to GA #104636

merged 1 commit into from Nov 10, 2021

Conversation

hbagdi
Copy link
Contributor

@hbagdi hbagdi commented Aug 27, 2021

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This graduates IngressClass.Spec.Parameters.Namespace field to GA.

Does this PR introduce a user-facing change?

IngressClass.Spec.Parameters.Namespace field is now GA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig network
/cc @robscott

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2021
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@hbagdi
Copy link
Contributor Author

hbagdi commented Nov 8, 2021

/priority important-soon

@hbagdi hbagdi force-pushed the ingress-class-namespaced-params-ga branch from fa8cbc5 to 3b4f369 Compare November 8, 2021 18:15
@hbagdi hbagdi mentioned this pull request Nov 8, 2021
Merged
@robscott
Copy link
Member

robscott commented Nov 8, 2021

Not sure this is strictly required, but may be good to add this field to one of our existing conformance tests to ensure that the field can be set. Maybe somewhere around here: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/network/ingress.go#L606.

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 8, 2021
@robscott
Copy link
Member

robscott commented Nov 8, 2021

I think it's also typical to remove any feature gate checks at this point since we have LockToDefault: true. Here's a previous similar PR for reference: #96327

@hbagdi hbagdi force-pushed the ingress-class-namespaced-params-ga branch from 3b4f369 to 39c9337 Compare November 8, 2021 19:17
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2021
@hbagdi hbagdi force-pushed the ingress-class-namespaced-params-ga branch from 39c9337 to bb640e7 Compare November 8, 2021 19:49
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 8, 2021
@hbagdi hbagdi force-pushed the ingress-class-namespaced-params-ga branch 2 times, most recently from 0163b6c to 276b86b Compare November 8, 2021 21:01
@robscott
Copy link
Member

robscott commented Nov 8, 2021

Thanks!

/lgtm
/assign @thockin

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@hbagdi hbagdi force-pushed the ingress-class-namespaced-params-ga branch from 276b86b to f3e2b63 Compare November 8, 2021 22:40
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@thockin
Copy link
Member

thockin commented Nov 8, 2021

/approve

Needs a new LGTM from Rob

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbagdi, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@hbagdi hbagdi force-pushed the ingress-class-namespaced-params-ga branch from f3e2b63 to ace07d4 Compare November 9, 2021 00:04
@hbagdi
Copy link
Contributor Author

hbagdi commented Nov 9, 2021

/test pull-kubernetes-integration

robscott
robscott reviewed Nov 9, 2021
View reviewed changes
test/e2e/network/ingressclass.go Outdated
}
if createdIngressClass.Spec.Parameters.Scope == nil ||
*createdIngressClass.Spec.Parameters.Scope != "Namespace" {
framework.Failf("Expected IngressClass.spec.parameters.scope to be set to 'Namespace'")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could likely use a got %v extension - would also help clarify why this particular part of the test is failing.

aojea
aojea reviewed Nov 9, 2021
View reviewed changes
test/e2e/network/ingressclass.go Outdated
framework.Failf("Expected IngressClass.spec.parameters.scope to be set to 'Namespace'")
}

framework.ExpectNoError(err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should go just after the call to the function that returns the variable,no?

aojea
aojea reviewed Nov 9, 2021
View reviewed changes
test/e2e/network/ingressclass.go
Comment on lines +121 to +126
if createdIngressClass.Spec.Parameters == nil {
framework.Failf("Expected IngressClass.spec.parameters to be set")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CI job fails here

/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/ingressclass.go:100
Nov 9 01:49:18.288: Expected IngressClass.spec.parameters to be set
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes/runner.go:113

is the ingress version used in the CI supporting it? otherwise we have to modify the job in test-infra to skip this test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the ingress version used in the CI supporting it?

I'm not sure if that even matters because the test creates an IngressClass resource (and not an Ingress resource).

I've fixed the test to include a more descriptive error message and fixed the ordering.
Another run should point out the issues.

@hbagdi hbagdi force-pushed the ingress-class-namespaced-params-ga branch 2 times, most recently from 4f28f9a to 4cffe5c Compare November 9, 2021 19:10
@hbagdi
Copy link
Contributor Author

hbagdi commented Nov 9, 2021

/test pull-kubernetes-e2e-gci-gce-ingress

@hbagdi hbagdi force-pushed the ingress-class-namespaced-params-ga branch from 4cffe5c to d09a8c0 Compare November 10, 2021 16:58
@hbagdi
Copy link
Contributor Author

hbagdi commented Nov 10, 2021

@robscott CI is green. PTAL.

@robscott
Copy link
Member

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1ff64ed into kubernetes:master Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 10, 2021
@hbagdi hbagdi deleted the ingress-class-namespaced-params-ga branch November 10, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@aojea aojea aojea left review comments

Assignees

@robscott robscott

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hbagdi @k8s-triage-robot @robscott @thockin @k8s-ci-robot @aojea