New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition in logging when request times out #105734
Conversation
/assign @wojtek-t |
/retest |
99d3182
to
84b6c0c
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @liggitt
84b6c0c
to
bda82c4
Compare
/test pull-kubernetes-kubemark-e2e-gce-big |
/triage accepted |
/assign @sttts |
bda82c4
to
269431c
Compare
/assign @tkashem |
/lgtm Thanks! |
/lgtm @marseel - can you please open cherrypicks once this PR merges? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marseel, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
…734-upstream-release-1.20 Automated cherry pick of #105734: Fix race condition in logging when request times out
…734-upstream-release-1.22 Automated cherry pick of #105734: Fix race condition in logging when request times out
…734-upstream-release-1.21 Automated cherry pick of #105734: Fix race condition in logging when request times out
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes race condition:
kubernetes/staging/src/k8s.io/apiserver/pkg/server/filters/timeout.go
Line 96 in a78e313
kubernetes/staging/src/k8s.io/apiserver/pkg/endpoints/filters/authentication.go
Line 77 in a78e313
This can cause unrecoverable panic that crashes apiserver(this stacktrace was based on 1.21 version):
I've also looked briefly and found two other possible race conditions when accessing/modifying addedInfo or addedKeyValuePairs (although I haven't observed such error in real cluster as compared to this panic above).
Which issue(s) this PR fixes:
Fixes #105759
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: