Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WindowsHostProcessContainers feature-gate to Beta #106058

Merged
merged 1 commit into from Nov 9, 2021
Merged

Move WindowsHostProcessContainers feature-gate to Beta #106058

merged 1 commit into from Nov 9, 2021

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Nov 1, 2021

Signed-off-by: Mark Rossetti marosset@microsoft.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR moves the WindowsHostProcessContainers feature to beta

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#1981

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Moving WindowsHostProcessContainers feature to beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/1981-windows-privileged-container-support

/hold
/sig windows
/milestone v1.23

@marosset
Move WindowsHostProcessContainers feature-gate to Beta
d16c1f1 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Nov 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 1, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 1, 2021
@k8s-ci-robot
Copy link
Contributor

@marosset: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2021
@marosset
Copy link
Contributor Author

marosset commented Nov 1, 2021

Adding a hold to this PR until the beta PRs linked to kubernetes/enhancements#1981 are all merged.

@marosset marosset mentioned this pull request Nov 1, 2021
Closed
35 tasks
@marosset marosset added this to In Review (v1.23) in SIG-Windows Nov 4, 2021
@marosset
Copy link
Contributor Author

marosset commented Nov 8, 2021

/test pull-kubernetes-e2e-kind

@marosset
Copy link
Contributor Author

marosset commented Nov 8, 2021

/hold cancel
/assign @jsturtevant @jayunit100 @claudiubelu

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2021
@jsturtevant
Copy link
Contributor

lgtm I reviewed the items at https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/1981-windows-privileged-container-support#test-plan and https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/1981-windows-privileged-container-support#graduation-criteria

@jayunit100
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit d3ef2e3 into kubernetes:master Nov 9, 2021
SIG-Windows automation moved this from In Review (v1.23) to Done (v1.23) Nov 9, 2021
@marosset marosset deleted the host-process-containers-beta branch November 10, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@jsturtevant jsturtevant

@jayunit100 jayunit100

@claudiubelu claudiubelu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG-Windows
  
Done (v1.23)
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marosset @k8s-ci-robot @jsturtevant @jayunit100 @claudiubelu