New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scheduler] Remove deprecated volumeSchedulingLatency metric #104518
[scheduler] Remove deprecated volumeSchedulingLatency metric #104518
Conversation
@dntosas: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @dntosas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -378,7 +377,7 @@ func (b *volumeBinder) AssumePodVolumes(assumedPod *v1.Pod, nodeName string, pod | |||
klog.V(4).Infof("AssumePodVolumes for pod %q, node %q", podName, nodeName) | |||
start := time.Now() | |||
defer func() { | |||
metrics.VolumeSchedulingStageLatency.WithLabelValues("assume").Observe(time.Since(start).Seconds()) | |||
metrics..WithLabelValues("assume").Observe(time.Since(start).Seconds()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metrics..WithLabelValues
is illegal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg, wrong delete shortcut 😋 thanks ^
a8701cd
to
9f6d18d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
+ go install ./cmd/...
# k8s.io/kubernetes/pkg/scheduler/framework/plugins/volumebinding
pkg/scheduler/framework/plugins/volumebinding/binder.go:293:2: start declared but not used
pkg/scheduler/framework/plugins/volumebinding/binder.go:378:2: start declared but not used
pkg/scheduler/framework/plugins/volumebinding/binder.go:451:2: start declared but not used @dntosas please remove unused |
As part of kubernetes#100720 we backported fix on existing releases and in this commit we completely remove the deprecated metric from master branch. Signed-off-by: dntosas <ntosas@gmail.com>
9f6d18d
to
cd795fa
Compare
Can you modify your release note with the full metric name /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dntosas, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sure, done ^^ |
Thanks! |
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/retest |
is there an alternative metric consumers should switch to? can that be indicated in the release note? |
|
As part of #100720 we backported fix on existing releases and
in this commit we completely remove the deprecated metric from the master branch.
Signed-off-by: dntosas ntosas@gmail.com
What type of PR is this?
/kind cleanup
/kind deprecation
Does this PR introduce a user-facing change?