Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move configurable fsgroup to GA #105885

Merged
merged 4 commits into from Nov 10, 2021
Merged

Move configurable fsgroup to GA #105885

merged 4 commits into from Nov 10, 2021

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Oct 25, 2021 •
edited

Move configurable fsgroup feature to GA.

Also rename metric that reports time taken to change permissions - #104717

xref kubernetes/enhancements#695

cc @msau42 @mattcary

/sig storage

Move ConfigurableFSGroupPolicy to GA
Rename metric volume_fsgroup_recursive_apply to volume_apply_access_control

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 25, 2021
@gnufied
Copy link
Member Author

gnufied commented Oct 26, 2021

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2021
@msau42
Copy link
Member

msau42 commented Nov 2, 2021

Can you add a release note indicating that the metric name is changing? Do we have any e2e tests that the metric would need to update?

msau42
msau42 reviewed Nov 2, 2021
View reviewed changes
pkg/features/kube_features.go Outdated
@@ -816,7 +817,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
InTreePluginvSphereUnregister: {Default: false, PreRelease: featuregate.Alpha},
CSIMigrationOpenStack: {Default: true, PreRelease: featuregate.Beta},
InTreePluginOpenStackUnregister: {Default: false, PreRelease: featuregate.Alpha},
ConfigurableFSGroupPolicy: {Default: true, PreRelease: featuregate.Beta},
ConfigurableFSGroupPolicy: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed in 1.25 according to deprecation policy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@dashpole
Copy link
Contributor

dashpole commented Nov 4, 2021

/assign
/triage accepted
(lgtm from instrumentation)

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 4, 2021
@gnufied gnufied force-pushed the move-configurable-fsgroup-ga branch from 7781836 to 9d9c300 Compare November 8, 2021 21:41
@gnufied
Copy link
Member Author

gnufied commented Nov 8, 2021

@msau42 updated release note. Also no, I don't think there are any e2e that depend on that metric.

@msau42
Copy link
Member

msau42 commented Nov 8, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@msau42
Copy link
Member

msau42 commented Nov 8, 2021

/assign @thockin

@thockin
Copy link
Member

thockin commented Nov 8, 2021

I sitll see references to this gate in pkg/api/pod/util.go pkg/volume/volume_linux.go pkg/volume/volume_linux_test.go

@gnufied
Copy link
Member Author

gnufied commented Nov 9, 2021

@thockin I thought until feature gate is really removed, some of the tests/code can carry featuregate references? Not trying to use as an excuse but I saw similar examples elsewhere (i.e feature is being GAed but has some references in code).

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@thockin
Copy link
Member

thockin commented Nov 10, 2021

Generally GA means to remove gated code

@thockin
Copy link
Member

thockin commented Nov 10, 2021

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, msau42, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit dcf0a03 into kubernetes:master Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 10, 2021
@xing-yang xing-yang mentioned this pull request Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@Jiawei0227 Jiawei0227 Awaiting requested review from Jiawei0227

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@dashpole dashpole

@thockin thockin

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gnufied @msau42 @dashpole @thockin @k8s-ci-robot