fix AsApproximateFloat64() for BinarySI #103751

y-tag · 2021-07-16T23:19:19Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Since Format, such as DecimalSI and BinarySI, would be used for conversion from/to string, the value of AsApproximateFloat64() does not depend on Format.

After applying this patch, the result of main.go in #103748 changes as follow:

$ go run main.go 
s: 3750, v: 3750, f: 3750
s: 7500k, v: 7500000, f: 7.5e+06
s: 2250M, v: 2250000000, f: 2.25e+09
s: 3840, v: 3840, f: 3840.0000000000005
s: 7680Ki, v: 7864320, f: 7.864320000000001e+06
s: 2304Mi, v: 2415919104, f: 2.415919104e+09

Does this PR introduce a user-facing change?

Scheduler resource metrics over fractional binary quantities (2.5Gi, 1.1Ki) were incorrectly reported as very small values.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2021-07-16T23:19:27Z

Welcome @y-tag!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-07-16T23:19:28Z

Hi @y-tag. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fedebongio · 2021-07-20T20:11:16Z

/assign @yliaog
/triage accepted

yliaog · 2021-07-20T21:14:34Z

/ok-to-test

y-tag · 2021-07-21T08:55:59Z

/retest

yliaog · 2021-07-23T18:37:10Z

/lgtm

y-tag · 2021-08-06T12:51:43Z

/assign @deads2k

y-tag · 2021-08-31T07:45:43Z

/unassign @deads2k
/assign @liggitt

y-tag · 2021-09-02T20:36:29Z

@liggitt I would be grateful for your approval of this PR.

liggitt · 2021-09-03T16:01:38Z

/unassign
/assign @smarterclayton
as original author (c06c112)

smarterclayton · 2021-09-03T16:25:07Z

staging/src/k8s.io/apimachinery/pkg/api/resource/quantity_test.go

+		{decQuantity(7*1024*1024, 4, BinarySI), (7 * 1024 * 1024) * 10000},
+		{decQuantity(7*1024*1024, 8, BinarySI), (7 * 1024 * 1024) * 100000000},
+		{decQuantity(7*1024*1024, -1, BinarySI), (7 * 1024 * 1024) * math.Pow10(-1)}, // '* Pow10' and '/ float(10)' do not round the same way
+		{decQuantity(7*1024*1024, -8, BinarySI), (7 * 1024 * 1024) / float64(100000000)},


Looks correct, please pull in the changes in #104757 (the additional test added to quantity_test.go and the change to scheduler resources_test.go to surface the problem).

The release note needs to be changed to read:

Scheduler resource metrics over fractional binary quantities (2.5Gi, 1.1Ki) were incorrectly reported as very small values.

I appreciate your help! 🙇
I pulled in the changes in #104757 and updated the release note.

smarterclayton · 2021-09-03T16:25:42Z

Looks good except for the additional test changes. Once those are integrated and the release note updated I'll tag.

ehashman · 2021-09-03T16:42:56Z

/priority important-soon

Fractional binary SI quantities that cannot be represented as decimal internally were incorrectly calculated.

y-tag · 2021-09-08T21:04:13Z

@smarterclayton Could you check if I have followed your instructions?
I added your commit to this PR and updated the release note. Thank you!

smarterclayton · 2021-09-09T14:16:03Z

/lgtm
/approve

Thanks!

k8s-ci-robot · 2021-09-09T14:16:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, y-tag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/scheduler/OWNERS~~ [smarterclayton]
~~staging/src/k8s.io/apimachinery/pkg/OWNERS~~ [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fix AsApproximateFloat64() for BinarySI

3d1076e

k8s-ci-robot requested review from smarterclayton and xiang90 July 16, 2021 23:19

k8s-ci-robot assigned yliaog Jul 20, 2021

k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 20, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2021

k8s-ci-robot assigned deads2k Aug 6, 2021

k8s-ci-robot assigned liggitt and unassigned deads2k Aug 31, 2021

k8s-ci-robot assigned smarterclayton and unassigned liggitt Sep 3, 2021

smarterclayton mentioned this pull request Sep 3, 2021

DO NOT MERGE: Additional resource quantity testing #104757

Closed

smarterclayton reviewed Sep 3, 2021

View reviewed changes

k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 3, 2021

Additional resource quantity testing

2d7a916

Fractional binary SI quantities that cannot be represented as decimal internally were incorrectly calculated.

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2021

k8s-ci-robot merged commit c0c7039 into kubernetes:master Sep 9, 2021

k8s-ci-robot added this to the v1.23 milestone Sep 9, 2021

y-tag deleted the approx-float64 branch September 9, 2021 20:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix AsApproximateFloat64() for BinarySI #103751

fix AsApproximateFloat64() for BinarySI #103751

y-tag commented Jul 16, 2021 •

edited

k8s-ci-robot commented Jul 16, 2021

k8s-ci-robot commented Jul 16, 2021

fedebongio commented Jul 20, 2021

yliaog commented Jul 20, 2021

y-tag commented Jul 21, 2021

yliaog commented Jul 23, 2021

y-tag commented Aug 6, 2021

y-tag commented Aug 31, 2021

y-tag commented Sep 2, 2021

liggitt commented Sep 3, 2021

smarterclayton Sep 3, 2021 •

edited

y-tag Sep 4, 2021

smarterclayton commented Sep 3, 2021

ehashman commented Sep 3, 2021

y-tag commented Sep 8, 2021

smarterclayton commented Sep 9, 2021

k8s-ci-robot commented Sep 9, 2021

fix AsApproximateFloat64() for BinarySI #103751

fix AsApproximateFloat64() for BinarySI #103751

Conversation

y-tag commented Jul 16, 2021 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Jul 16, 2021

k8s-ci-robot commented Jul 16, 2021

fedebongio commented Jul 20, 2021

yliaog commented Jul 20, 2021

y-tag commented Jul 21, 2021

yliaog commented Jul 23, 2021

y-tag commented Aug 6, 2021

y-tag commented Aug 31, 2021

y-tag commented Sep 2, 2021

liggitt commented Sep 3, 2021

smarterclayton Sep 3, 2021 • edited

Choose a reason for hiding this comment

y-tag Sep 4, 2021

Choose a reason for hiding this comment

smarterclayton commented Sep 3, 2021

ehashman commented Sep 3, 2021

y-tag commented Sep 8, 2021

smarterclayton commented Sep 9, 2021

k8s-ci-robot commented Sep 9, 2021

y-tag commented Jul 16, 2021 •

edited

smarterclayton Sep 3, 2021 •

edited