Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add condition pre-check for pod uid and pod resource version in bind api #105913

Merged
merged 1 commit into from Nov 2, 2021
Merged

add condition pre-check for pod uid and pod resource version in bind api #105913

merged 1 commit into from Nov 2, 2021
+146 −5

Conversation

aholic
Copy link
Contributor

@aholic aholic commented Oct 26, 2021 •
edited by liggitt

What type of PR is this?

/kind bug

What this PR does / why we need it:

try to fix #105261 and #102761

Which issue(s) this PR fixes:

Fixes #105261 #102761

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The pods/binding subresource now honors `metadata.uid` and `metadata.resourceVersion` preconditions

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 26, 2021
@k8s-ci-robot
Copy link
Contributor

@aholic: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @aholic!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 26, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @aholic. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aholic aholic force-pushed the master branch 2 times, most recently from 3e49d86 to cdee60f Compare October 26, 2021 17:17
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 26, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Oct 27, 2021
@MadhavJivrajani
Copy link
Contributor

/sig scheduling
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 27, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2021
@aholic
Copy link
Contributor Author

aholic commented Oct 27, 2021

@aholic: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd 1058b5d link true /test pull-kubernetes-e2e-gce-ubuntu-containerd
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

/test pull-kubernetes-e2e-gce-ubuntu-containerd

Huang-Wei
Huang-Wei reviewed Oct 27, 2021
View reviewed changes
pkg/registry/core/pod/storage/storage.go Outdated Show resolved Hide resolved
pkg/registry/core/pod/storage/storage_test.go Outdated Show resolved Hide resolved
pkg/registry/core/pod/storage/storage_test.go Outdated Show resolved Hide resolved
@aholic
Copy link
Contributor Author

aholic commented Oct 28, 2021

@aholic: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-containerd 5edbe27 link true /test pull-kubernetes-node-e2e-containerd
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

/test pull-kubernetes-node-e2e-containerd

@Huang-Wei
Copy link
Member

LGTM, but I'm not an API expert.

@liggitt could you review to see if it functions well and the UT's coverage suffices?

liggitt
liggitt reviewed Nov 1, 2021
View reviewed changes
pkg/registry/core/pod/storage/storage.go Outdated Show resolved Hide resolved
pkg/registry/core/pod/storage/storage.go Outdated Show resolved Hide resolved
pkg/registry/core/pod/storage/storage_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2021
@aholic aholic changed the title add condition pre-check for pod uid in bind api add condition pre-check for pod uid and pod resource version in bind api Nov 1, 2021
@liggitt
Copy link
Member

liggitt commented Nov 2, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aholic, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5aacb15 into kubernetes:master Nov 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 2, 2021
@Huang-Wei Huang-Wei mentioned this pull request Nov 5, 2021
Closed
@Huang-Wei Huang-Wei mentioned this pull request Nov 15, 2021
Merged
This was referenced Nov 16, 2021
Closed
Closed
@ahg-g ahg-g mentioned this pull request Nov 25, 2021
Merged
@alculquicondor alculquicondor mentioned this pull request Mar 13, 2023
Merged
@alculquicondor
Copy link
Member

FYI, this never solved the problem because the UID is actually wiped before it reaches the storage layer.

#116550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@kerthcet kerthcet kerthcet left review comments

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Bind api will bind unexpected pod to node in some situation
7 participants
@aholic @k8s-ci-robot @MadhavJivrajani @Huang-Wei @liggitt @alculquicondor @kerthcet