Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CSIVolumeFSGroupPolicy feature to GA #105940

Merged
merged 1 commit into from Nov 4, 2021
Merged

Move CSIVolumeFSGroupPolicy feature to GA #105940

merged 1 commit into from Nov 4, 2021

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Oct 27, 2021 •
edited

This updates the feature gates to move CSIVolumeFSGroupPolicy from beta to GA in 1.23.

What type of PR is this?

/kind feature
/sig storage
/milestone v1.23

Which issue(s) this PR fixes:

Enhancement: kubernetes/enhancements#1682

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The CSIVolumeFSGroupPolicy feature has moved from beta to GA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @gnufied @msau42 @xing-yang

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 27, 2021
@k8s-ci-robot
Copy link
Contributor

@dobsonj: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

This updates the feature gates to move CSIVolumeFSGroupPolicy from beta to GA in 1.23.

What type of PR is this?

/kind feature
/sig storage
/milestone v1.23

Which issue(s) this PR fixes:

Issue: kubernetes/enhancements#1682

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The CSIVolumeFSGroupPolicy feature has moved to GA and is enabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @gnufied @msau42 @xing-yang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 27, 2021
This was referenced Oct 27, 2021
Closed
Merged
Merged
Closed
@dobsonj
Copy link
Member Author

dobsonj commented Oct 28, 2021

/retest

@dobsonj
Copy link
Member Author

dobsonj commented Oct 28, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 28, 2021
@dobsonj
Copy link
Member Author

dobsonj commented Oct 29, 2021

/retest

1 similar comment
@dobsonj
Copy link
Member Author

dobsonj commented Oct 29, 2021

/retest

@dobsonj
Copy link
Member Author

dobsonj commented Nov 1, 2021

/cc @jsafrane

@msau42
Copy link
Member

msau42 commented Nov 2, 2021

/approve

msau42
msau42 reviewed Nov 2, 2021
View reviewed changes
pkg/features/kube_features.go Outdated
@@ -835,7 +836,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
CSIStorageCapacity: {Default: true, PreRelease: featuregate.Beta},
CSIServiceAccountToken: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.23
GenericEphemeralVolume: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.25
CSIVolumeFSGroupPolicy: {Default: true, PreRelease: featuregate.Beta},
CSIVolumeFSGroupPolicy: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the deprecation policy is 2 releases, so this should be 1.25

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thank you, updated.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2021
msau42
msau42 reviewed Nov 2, 2021
View reviewed changes
pkg/apis/storage/types.go Outdated
@@ -283,8 +283,8 @@ type CSIDriverSpec struct {
// Defines if the underlying volume supports changing ownership and
// permission of the volume before being mounted.
// Refer to the specific FSGroupPolicy values for additional details.
// This field is beta, and is only honored by servers
// that enable the CSIVolumeFSGroupPolicy feature gate.
// This field is only honored by servers that enable the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this line altogether as the feature is locked to on and can't be disabled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the versioned (v1, v1beta, etc) types.go as well.

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@msau42
Copy link
Member

msau42 commented Nov 2, 2021

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Nov 2, 2021
@msau42
Copy link
Member

msau42 commented Nov 2, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2021
@dobsonj
Copy link
Member Author

dobsonj commented Nov 3, 2021

/assign @thockin

thockin
thockin reviewed Nov 4, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, msau42, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2af34cf into kubernetes:master Nov 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@msau42 msau42 msau42 left review comments

@gnufied gnufied Awaiting requested review from gnufied

@xing-yang xing-yang Awaiting requested review from xing-yang

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@thockin thockin

@msau42 msau42

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dobsonj @k8s-ci-robot @msau42 @k8s-triage-robot @thockin