New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UID to client-go impersonation config #104483
Conversation
Hi @margocrawf. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/assign @deads2k |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically the same comment a bunch of times about field ordering to match the rest of the codebase.
/lgtm |
/assign @smarterclayton |
* Updates ImpersonationConfig in rest/config.go to include UID attribute, and pass it through when copying the config * Updates ImpersonationConfig in transport/config.go to include UID attribute * In transport/round_tripper.go, Set the "Impersonate-Uid" header in requests based on the UID value in the config * Update auth_test.go integration test to specify a UID through the new rest.ImpersonationConfig field rather than manually setting the Impersonate-Uid header Signed-off-by: Margo Crawford <margaretc@vmware.com>
/lgtm |
/uncc johnSchnake krousey |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, margocrawf, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This corresponds to previous work to allow impersonating UIDs: * Introduce Impersonate-UID header: kubernetes#99961 * Add UID to client-go impersonation config kubernetes#104483 Signed-off-by: Margo Crawford <margaretc@vmware.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Introduces Impersonate-UID to client-go. My previous PR introduced the
Impersonate-UID
header, this PR makes it possible to specify the UID in your impersonation config on the client side in order to pass theImpersonate-UID
header along with a request.attribute, and pass it through when copying the config
attribute
requests based on the UID value in the config
rest.ImpersonationConfig field rather than manually setting the
Impersonate-Uid header
Which issue(s) this PR fixes:
This is another piece of addressing #93699. It is a follow up to #99961.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: