Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed buckets for apiserver_request_duration_seconds metric #106306

Merged
merged 1 commit into from Nov 10, 2021
Merged

Changed buckets for apiserver_request_duration_seconds metric #106306

merged 1 commit into from Nov 10, 2021

Conversation

pawbana
Copy link
Contributor

@pawbana pawbana commented Nov 10, 2021 •
edited

/kind cleanup

What this PR does / why we need it:

As discussed in pr/105890 (see comment) buckets in apiserver_request_duration_seconds metric are rearranged to save space.

Which issue(s) this PR fixes:

Fixes issue: #105346

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Changed buckets in apiserver_request_duration_seconds metric from [0.05, 0.1, 0.15, 0.2, 0.25, 0.3, 0.35, 0.4, 0.45, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0,1.25, 1.5, 1.75, 2.0, 2.5, 3.0, 3.5, 4.0, 4.5, 5, 6, 7, 8, 9, 10, 15, 20, 25, 30, 40, 50, 60] to [0.05, 0.1, 0.2, 0.4, 0.6, 0.8, 1.0, 1.25, 1.5, 2, 3, 4, 5, 6, 8, 10, 15, 20, 30, 45, 60]

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @pawbana. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 10, 2021
@pawbana pawbana force-pushed the change_bucketing_for_request_latency_metric branch from d57a5e8 to a8bd20a Compare November 10, 2021 11:54
@dgrisonnet
Copy link
Member

Thanks @pawbana for splitting this change. Could you mention in the PR description that it fixes #105346?

/ok-to-test
/lgtm

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@pawbana
Copy link
Contributor Author

pawbana commented Nov 10, 2021

Thanks @pawbana for splitting this change. Could you mention in the PR description that it fixes #105346?

/ok-to-test /lgtm

/assign @wojtek-t

Done

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawbana, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit b817efb into kubernetes:master Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 10, 2021
@pawbana pawbana mentioned this pull request Nov 10, 2021
Merged
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 11, 2021
@pawbana pawbana deleted the change_bucketing_for_request_latency_metric branch December 22, 2021 14:11
@wojtek-t wojtek-t mentioned this pull request Jan 10, 2022
Closed
tkashem added a commit to tkashem/kubernetes that referenced this pull request Jan 24, 2022
@tkashem
UPSTREAM: <drop>: Revert "Merge pull request kubernetes#106306 from p…
de1d569 
…awbana/change_bucketing_for_request_latency_metric"

This reverts commit b817efb, reversing
changes made to 5a81905.
dgrisonnet added a commit to dgrisonnet/kubernetes that referenced this pull request Jan 25, 2022
@dgrisonnet
UPSTREAM: revert: 1130: Revert "Merge pull request kubernetes#106306 …
f0c508d 
…from pawbana/change_bucketing_for_request_latency_metric"

This reverts commit de1d569.
@junkiebev junkiebev mentioned this pull request Mar 17, 2022
Open
@pawbana pawbana mentioned this pull request Aug 3, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmidyson jimmidyson Awaiting requested review from jimmidyson

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@wojtek-t wojtek-t

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pawbana @k8s-ci-robot @dgrisonnet @wojtek-t @fedebongio