Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock StorageObjectInUseProtection feature gate to default #105495

Merged
merged 2 commits into from Oct 20, 2021
Merged

Lock StorageObjectInUseProtection feature gate to default #105495

merged 2 commits into from Oct 20, 2021

Conversation

ikeeip
Copy link
Contributor

@ikeeip ikeeip commented Oct 5, 2021 •
edited

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Lock StorageObjectInUseProtection feature gate to default.

Which issue(s) this PR fixes:

Fixes N/A

Special notes for your reviewer:

Additional PR to make locking to default first before removing feature gates logic (#104903).

Does this PR introduce a user-facing change?

-  Feature-gate `StorageObjectInUseProtection` has been deprecated and cannot be disabled. It will be completely removed in 1.25

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 5, 2021
@k8s-ci-robot
Copy link
Contributor

@ikeeip: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @ikeeip. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 5, 2021
@ikeeip ikeeip mentioned this pull request Oct 5, 2021
Merged
@ikeeip
Copy link
Contributor Author

ikeeip commented Oct 5, 2021

/cc @msau42 @deads2k

msau42
msau42 reviewed Oct 5, 2021
View reviewed changes
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a release note to indicate that the feature gate is deprecated?

pkg/features/kube_features.go Outdated Show resolved Hide resolved
@ikeeip ikeeip force-pushed the storageobjectinuseprotection_lock_to_default branch from ec7d48e to 1349451 Compare October 6, 2021 14:21
@ikeeip
Copy link
Contributor Author

ikeeip commented Oct 6, 2021

Can you add a release note to indicate that the feature gate is deprecated?

But isn't this enough?

Does this PR introduce a user-facing change?

- The `StorageObjectInUseProtection` graduated to GA in v1.11 and is unconditionally enabled now.

@msau42
Copy link
Member

msau42 commented Oct 7, 2021

I prefer that we explicitly state a feature gate is deprecated and shouldn't be used anymore, however I also took a look at a couple of other feature graduation PRs and don't see any mention of this. @deads2k do you think this is something we should be doing going forward?

@msau42
Copy link
Member

msau42 commented Oct 15, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2021
@ikeeip
Lock StorageObjectInUseProtection feature gate to default
e07d736 
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
@ikeeip
Remove tests when StorageObjectInUseProtection feature is disabled
dbc9d7b 
As well as feature gate are locked, the tests when this feature is
disabled will crash. So we should remove them together with locking
the feature.

Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
@ikeeip ikeeip force-pushed the storageobjectinuseprotection_lock_to_default branch from 1349451 to dbc9d7b Compare October 15, 2021 11:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 15, 2021
@ikeeip
Copy link
Contributor Author

ikeeip commented Oct 15, 2021

/retest

@msau42
Copy link
Member

msau42 commented Oct 20, 2021

I didn't get any response regarding the specific deprecation wording recommendation for the release note, and it doesn't look like we've been doing this for other features, so this looks ok.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ikeeip, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit dea14db into kubernetes:master Oct 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 20, 2021
@sftim
Copy link
Contributor

sftim commented Oct 20, 2021

Would it be possible to mention the words “feature gate” in the release note here?

@sftim
Copy link
Contributor

sftim commented Oct 20, 2021

See #105474 for an example of wording.

@ikeeip
Copy link
Contributor Author

ikeeip commented Oct 21, 2021

Would it be possible to mention the words “feature gate” in the release note here?

Yes, fixed.

See #105474 for an example of wording.

Thanks for the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ikeeip @k8s-ci-robot @msau42 @sftim