Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ServiceAccountIssuerDiscovery feature gate #103685

Merged
merged 1 commit into from Aug 9, 2021
Merged

Remove ServiceAccountIssuerDiscovery feature gate #103685

merged 1 commit into from Aug 9, 2021

Conversation

mengjiao-liu
Copy link
Member

@mengjiao-liu mengjiao-liu commented Jul 14, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

The ServiceAccountIssuerDiscovery feature has graduated to GA in 1.21, and is unconditionally enabled. The ServiceAccountIssuerDiscovery feature-gate can be safely removed in 1.23.

kubernetes/pkg/features/kube_features.go

Line 836 in 2da4d48

ServiceAccountIssuerDiscovery: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.22

xref #98553

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The ServiceAccountIssuerDiscovery feature gate is removed. It reached GA in Kubernetes 1.21.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/1393-oidc-discovery

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2021
@mengjiao-liu
Copy link
Member Author

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jul 14, 2021
@mengjiao-liu
Copy link
Member Author

/milestone v1.22

@k8s-ci-robot
Copy link
Contributor

@mengjiao-liu: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mengjiao-liu
Copy link
Member Author

/assign @deads2k

@mengjiao-liu
Copy link
Member Author

The ServiceAccountIssuerDiscovery feature gate was originally planned to be removed in 1.22. Can this PR be labeled as a 1.22 milestone？@kubernetes/milestone-maintainers

@reylejano
Copy link
Member

Hi @mengjiao-liu ,

This would need an exception request for 1.22. According to the kep.yaml for Service Account signing key retrieval, this was GA in 1.21. Feature gates are generally removed 2 releases post GA

@mengjiao-liu
Copy link
Member Author

mengjiao-liu commented Jul 15, 2021 •
edited

This would need an exception request for 1.22. According to the kep.yaml for Service Account signing key retrieval, this was GA in 1.21. Feature gates are generally removed 2 releases post GA

I checked the documentation related to feature gate and compared to the cycle of deletion of other feature gates converted to GA, generally it can be deleted after a release version:

A General Availability (GA) feature is also referred to as a stable feature. It means:

  The feature is always enabled; you cannot disable it.
  The corresponding feature gate is no longer needed.

also the deprecating-a-feature-or-behavior doc:

GA, deprecation window complete: the feature gate is removed and calls to it are no longer accepted.

This removal does not have a significant effect and can be done in 1.23. Thanks!

@mengjiao-liu
Copy link
Member Author

/hold
Wait until 1.23 start.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2021
@enj enj added this to Needs Triage in SIG Auth Old Jul 15, 2021
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 15, 2021
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jul 15, 2021 •
edited

I checked the documentation related to feature gate and compared to the cycle of deletion of other feature gates converted to GA, generally it can be deleted after a release version:

A General Availability (GA) feature is also referred to as a stable feature. It means:

  The feature is always enabled; you cannot disable it.
  The corresponding feature gate is no longer needed.

also the deprecating-a-feature-or-behavior doc:

GA, deprecation window complete: the feature gate is removed and calls to it are no longer accepted.

This removal does not have a significant effect and can be done in 1.23. Thanks!

To clarify please see:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/feature-gates.md#ga-features

As well as (Rule 8):
https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecation

@mengjiao-liu
Copy link
Member Author

mengjiao-liu commented Jul 16, 2021 •
edited

Thanks for clarifying. I see.

So, this feature gate ServiceAccountIssuerDiscovery can be removed in version 1.23 or later, right?

@kikisdeliveryservice
Copy link
Member

Thanks for clarifying. I see.

So, this feature gate ServiceAccountIssuerDiscovery can be removed in version 1.23 or later, right?

yep 1.23 will put you at both 2 releases and 6+ months 👍

@mengjiao-liu
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2021
@mengjiao-liu
Copy link
Member Author

PTAL @deads2k @lavalamp @liggitt

@liggitt
Copy link
Member

liggitt commented Aug 9, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mengjiao-liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt moved this from Needs Triage to Closed / Done in SIG Auth Old Aug 9, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4f50f99 into kubernetes:master Aug 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth Old
Closed / Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mengjiao-liu @k8s-ci-robot @reylejano @fedebongio @kikisdeliveryservice @liggitt @deads2k