Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wait json #105776

Merged
merged 1 commit into from Nov 16, 2021
Merged

Add wait json #105776

merged 1 commit into from Nov 16, 2021

Conversation

lauchokyip
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allowed kubectl to wait on arbitrary jsonpath

Which issue(s) this PR fixes:

Fixes #83094

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added ability for kubectl wait to wait on arbitary JSON path

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 20, 2021
@lauchokyip lauchokyip changed the title Add wait json [WIP] Add wait json Oct 20, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2021
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 20, 2021
@lauchokyip
Copy link
Member Author

/cc @eddiezane

@lauchokyip lauchokyip mentioned this pull request Oct 20, 2021
Closed
@lauchokyip lauchokyip force-pushed the addWaitJson branch 2 times, most recently from ca79b21 to 8f5e0ad Compare October 27, 2021 18:41
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2021
@lauchokyip lauchokyip changed the title [WIP] Add wait json Add wait json Oct 27, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2021
@lauchokyip
Copy link
Member Author

@eddiezane Done with this PR, PTAL 😃

@eddiezane
Copy link
Member

/cc @KnVerey

brianpursley
brianpursley suggested changes Nov 5, 2021
View reviewed changes
staging/src/k8s.io/kubectl/pkg/cmd/wait/wait.go Outdated Show resolved Hide resolved
staging/src/k8s.io/kubectl/pkg/cmd/wait/wait_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/kubectl/pkg/cmd/wait/wait.go Outdated Show resolved Hide resolved
staging/src/k8s.io/kubectl/pkg/cmd/wait/wait.go Show resolved Hide resolved
staging/src/k8s.io/kubectl/pkg/cmd/wait/wait.go Outdated Show resolved Hide resolved
staging/src/k8s.io/kubectl/pkg/cmd/wait/wait.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 5, 2021
@seans3
Copy link
Contributor

seans3 commented Nov 5, 2021

/assign

@dims
Copy link
Member

dims commented Nov 10, 2021

/retest
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@lauchokyip
Copy link
Member Author

Thanks @dims ! I will squash the commit. Seem like it's almost ready

@dims
Copy link
Member

dims commented Nov 10, 2021

@lauchokyip please make sure you mark all the conversations are resolved as well.

@lauchokyip @eddiezane
Added JSONPath wait for kubectl wait
8fcf98e 
Co-authored-by: Eddie Zaneski <eddiezane@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@lauchokyip
Copy link
Member Author

@dims Done

eddiezane
eddiezane approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@eddiezane eddiezane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this!

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@seans3
Copy link
Contributor

seans3 commented Nov 16, 2021

/retest

Problem appears to be unrelated in the kubelet.

seans3
seans3 approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, eddiezane, lauchokyip, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6be67e8 into kubernetes:master Nov 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 16, 2021
@wking wking mentioned this pull request Nov 17, 2021
Merged
@jdef jdef mentioned this pull request Apr 7, 2022
Closed
@pierDipi pierDipi mentioned this pull request Apr 26, 2022
Merged
@jmcshane jmcshane mentioned this pull request Jun 17, 2022
Open
@dhduvall dhduvall mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley brianpursley requested changes

@eddiezane eddiezane eddiezane approved these changes

@seans3 seans3 seans3 approved these changes

@dougsland dougsland Awaiting requested review from dougsland

@KnVerey KnVerey Awaiting requested review from KnVerey

Assignees

@dims dims

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

kubectl wait on arbitrary jsonpath
6 participants
@lauchokyip @eddiezane @seans3 @dims @k8s-ci-robot @brianpursley