Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #108198: Updating EndpointSlice strategy to retain node name in #108203

Merged
merged 1 commit into from Feb 23, 2022
Merged

Automated cherry pick of #108198: Updating EndpointSlice strategy to retain node name in #108203

merged 1 commit into from Feb 23, 2022

Conversation

robscott
Copy link
Member

@robscott robscott commented Feb 17, 2022 •
edited by liggitt

Cherry pick of #108198 on release-1.21.

#108198: Updating EndpointSlice strategy to retain node name in

For details on the cherry pick process, see the cherry pick requests page.

Fixes a 1.21 regression bug where a partial EndpointSlice update could cause node name information to be dropped from endpoints that were not updated.

@robscott
Updating EndpointSlice strategy to retain node name in topology until…
590a1e3 
… field is set

This fixes a bug where a partial EndpointSlice update could cause node
name information to be dropped from endpoints that were not updated.
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 17, 2022
@robscott
Copy link
Member Author

/kind bug
/priority important-soon
/triage accepted
/sig network
/assign @thockin @liggitt

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 17, 2022
@liggitt
Copy link
Member

liggitt commented Feb 18, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 18, 2022
thockin
thockin reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member

liggitt commented Feb 18, 2022

cc @kubernetes/release-managers

@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Feb 18, 2022
@puerco
Copy link
Member

puerco commented Feb 23, 2022

Thanks @robscott !
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 23, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 621483e into kubernetes:release-1.21 Feb 23, 2022
@liggitt liggitt mentioned this pull request May 26, 2022
Closed
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@liggitt liggitt

@puerco puerco

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@robscott @liggitt @k8s-ci-robot @puerco @thockin