Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docker buildx for etcd image #104116

Merged
merged 1 commit into from Aug 11, 2021
Merged

Use docker buildx for etcd image #104116

merged 1 commit into from Aug 11, 2021

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

This allows to choose the correct architecture in the image manifest,
which defaulted to the host system before applying this patch.

Which issue(s) this PR fixes:

Refers to #104085

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed architecture within manifest for non `amd64` etcd images.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject labels Aug 4, 2021
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 4, 2021
@saschagrunert
Copy link
Member Author

So, I can only see this postsubmit which seems to build the images:
https://github.com/kubernetes/test-infra/blob/94d87522f5dc400ebdaeba52b6d78302ef3b6031/config/jobs/image-pushing/releng/k8s-staging-kubernetes.yaml#L1-L28

@saschagrunert
Copy link
Member Author

/test pull-kubernetes-integration

@dims
Copy link
Member

dims commented Aug 4, 2021

@saschagrunert let's update the REVISION as well ( https://github.com/kubernetes/kubernetes/blob/master/cluster/images/etcd/Makefile#L37 )

@saschagrunert
Use docker buildx for etcd image
ea1bc18 
This allows to choose the correct architecture in the image manifest,
which defaulted to the host system before applying this patch.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

@saschagrunert let's update the REVISION as well

Yep, done 👍

@justaugustus justaugustus added this to the v1.23 milestone Aug 4, 2021
@caesarxuchao
Copy link
Member

/assign @jpbetz @wenjiaswe
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 5, 2021
@jpbetz
Copy link
Contributor

jpbetz commented Aug 9, 2021

I'm not all that familiar with qemu-user-static, but from what I was able to glean after some reading suggests this should work fine.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2021
@jpbetz
Copy link
Contributor

jpbetz commented Aug 9, 2021

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 9, 2021
@pacoxu
Copy link
Member

pacoxu commented Aug 11, 2021

/lgtm
/cc @EricWvi
for #104257 you may bump the etcd version after this is merged.

@k8s-ci-robot
Copy link
Contributor

@pacoxu: GitHub didn't allow me to request PR reviews from the following users: EricWvi.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/lgtm
/cc @EricWvi
for #104257 you may bump the etcd version after this is merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2021
@pacoxu pacoxu mentioned this pull request Aug 11, 2021
Closed
@k8s-ci-robot k8s-ci-robot merged commit a21a328 into kubernetes:master Aug 11, 2021
@pacoxu
Copy link
Member

pacoxu commented Aug 11, 2021

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kubernetes-push-image-etcd/1425365086989455360

The postsubmit ci failed to run docker buildx.

@saschagrunert saschagrunert deleted the etcd-buildx branch August 11, 2021 08:22
@spiffxp
Copy link
Member

spiffxp commented Sep 27, 2021

What @pacoxu said, the postsubmit has been breaking ever since this merged

@spiffxp
Copy link
Member

spiffxp commented Sep 27, 2021

Last known good:

First bad:

This was referenced Sep 27, 2021
Closed
Merged
@spiffxp
Copy link
Member

spiffxp commented Sep 27, 2021

I opened #105284 to track and #105285 to revert to get us back to working builds before we figure out what the issue is

@saschagrunert saschagrunert mentioned this pull request Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

Assignees

@jpbetz jpbetz

@pacoxu pacoxu

@wenjiaswe wenjiaswe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@saschagrunert @dims @caesarxuchao @jpbetz @k8s-ci-robot @pacoxu @spiffxp @justaugustus @wenjiaswe