Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA TTLAfterFinish #105219

Merged
merged 1 commit into from Oct 8, 2021
Merged

GA TTLAfterFinish #105219

merged 1 commit into from Oct 8, 2021

Conversation

sahilvv
Copy link
Contributor

@sahilvv sahilvv commented Sep 23, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Graduates TTLAfterFinished feature to GA.

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#592

Special notes for your reviewer:

Does this PR introduce a user-facing change?

TTLAfterFinished is now GA and enabled by default

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/592-ttl-after-finish
kubernetes/enhancements#2841

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 23, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @sahilvv. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2021
@sahilvv
Copy link
Contributor Author

sahilvv commented Sep 23, 2021

/sig apps
/assign @soltysh @janetkuo
/milestone v1.23

@k8s-ci-robot
Copy link
Contributor

@sahilvv: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/sig apps
/assign @soltysh @janetkuo
/milestone v1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 23, 2021
@janetkuo
Copy link
Member

@ahg-g

@ahg-g
Copy link
Member

ahg-g commented Sep 24, 2021

can you please update the comments:

  1. kubernetes/pkg/apis/batch/types.go

    Line 176 in 86d23cf

    // This field is alpha-level and is only honored by servers that enable the

  2. kubernetes/staging/src/k8s.io/api/batch/v1/types.go

    Line 157 in 86d23cf

    // This field is alpha-level and is only honored by servers that enable the

@ahg-g
Copy link
Member

ahg-g commented Sep 24, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2021
@sahilvv
Copy link
Contributor Author

sahilvv commented Sep 24, 2021

/retest

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sahilvv
Copy link
Contributor Author

sahilvv commented Sep 26, 2021

/retest

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 7, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 7, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Oct 7, 2021
@sahilvv
Copy link
Contributor Author

sahilvv commented Oct 8, 2021

@msau42 @liggitt addressed the review feedback for removing featureGate from controllers and fixing the e2e test. Please review.

@liggitt
Copy link
Member

liggitt commented Oct 8, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, liggitt, sahilvv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 76c86ce into kubernetes:master Oct 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 8, 2021
This was referenced Oct 8, 2021
Closed
Merged
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 12, 2021
@sahilvv sahilvv mentioned this pull request Oct 26, 2021
Closed
7 tasks
@sahilvv sahilvv mentioned this pull request Nov 8, 2021
Closed
@mikkeloscar mikkeloscar mentioned this pull request Mar 17, 2023
Merged
@mengjiao-liu mengjiao-liu mentioned this pull request Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@janetkuo janetkuo janetkuo approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@thockin thockin Awaiting requested review from thockin

Assignees

@soltysh soltysh

@liggitt liggitt

@janetkuo janetkuo

@msau42 msau42

@ahg-g ahg-g

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.23
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@sahilvv @k8s-ci-robot @janetkuo @ahg-g @k8s-triage-robot @dims @msau42 @liggitt @fedebongio @soltysh