Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DelegateFSGroupToCSIDriver feature gate to beta #106330

Merged
merged 1 commit into from Nov 15, 2021
Merged

DelegateFSGroupToCSIDriver feature gate to beta #106330

merged 1 commit into from Nov 15, 2021

Conversation

verult
Copy link
Contributor

@verult verult commented Nov 10, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it: Move kubernetes/enhancements#2317 to beta.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

e2e test in progress

Does this PR introduce a user-facing change?

(beta feature) If the CSI driver supports the NodeServiceCapability `VOLUME_MOUNT_GROUP` and the `DelegateFSGroupToCSIDriver` feature gate is enabled, kubelet will delegate applying FSGroup to the driver by passing it to NodeStageVolume and NodePublishVolume, regardless of what other FSGroup policies are set.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/1a4f862a4bba0ca796b097a87a661e4f1c736fb2/keps/sig-storage/2317-fsgroup-on-mount/README.md
- [Usage]: https://github.com/kubernetes/website/blob/53f76125525d82cf679acc41cb464d244dbf00f0/content/en/docs/tasks/configure-pod-container/security-context.md?plain=1#L187

/assign @gnufied @msau42

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

@verult: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 10, 2021
@SergeyKanzhelev
Copy link
Member

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 11, 2021
@gnufied
Copy link
Member

gnufied commented Nov 11, 2021

Do you know if e2e tests pass for azurefile CSI driver after fsgroup is enabled? I am under the impression that those tests might need to be tweaked.

@verult
Copy link
Contributor Author

verult commented Nov 11, 2021

I'm also expecting OnRootMismatch tests in fsgroupchangepolicy.go to fail. Will need to update the e2e framework to skip those tests if the driver has volume mount group capability.

@gnufied gnufied mentioned this pull request Nov 11, 2021
Closed
12 tasks
msau42
msau42 reviewed Nov 12, 2021
View reviewed changes
pkg/features/kube_features.go
@@ -909,7 +910,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
PodSecurity: {Default: true, PreRelease: featuregate.Beta},
ReadWriteOncePod: {Default: false, PreRelease: featuregate.Alpha},
CSRDuration: {Default: true, PreRelease: featuregate.Beta},
DelegateFSGroupToCSIDriver: {Default: false, PreRelease: featuregate.Alpha},
DelegateFSGroupToCSIDriver: {Default: true, PreRelease: featuregate.Beta},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have feature-tagged e2e tests that need to be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this feature. Besides the test change in fsgroupchangepolicy.go above I'm planning to add tests explicitly verifying fsgroup delegation in this release.

@verult
Copy link
Contributor Author

verult commented Nov 15, 2021

/test pull-kubernetes-e2e-gce-alpha-features

@verult
Copy link
Contributor Author

verult commented Nov 15, 2021

OnRootMismatch tests are now skipped: #106395

PTAL again, thanks!

@gnufied
Copy link
Member

gnufied commented Nov 15, 2021

Lets fix the e2es in a follow up. For beta graduation this looks good to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@msau42
Copy link
Member

msau42 commented Nov 15, 2021

/approve

The existing fsgroup tests we have provide basic coverage. We can look at enhancing coverage later.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8260340 into kubernetes:master Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@gnufied gnufied

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@verult @k8s-ci-robot @SergeyKanzhelev @gnufied @msau42