Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PodSecurity: promote config and feature gate to beta #106089

Merged
merged 4 commits into from Nov 3, 2021
Merged

PodSecurity: promote config and feature gate to beta #106089

merged 4 commits into from Nov 3, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 2, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Promotes PodSecurity to beta

xref kubernetes/enhancements#2579

Does this PR introduce a user-facing change?

The PodSecurity admission plugin has graduated to beta and is enabled by default. The admission configuration version has been promoted to pod-security.admission.config.k8s.io/v1beta1. See https://kubernetes.io/docs/concepts/security/pod-security-admission/ for usage guidelines.

/sig auth
/assign @tallclair

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 2, 2021
@liggitt liggitt added this to In Review in SIG-Auth: PodSecurity via automation Nov 2, 2021
@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 2, 2021
@liggitt liggitt moved this from In Review to In Progress in SIG-Auth: PodSecurity Nov 2, 2021
@liggitt liggitt added this to the v1.23 milestone Nov 2, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 2, 2021
@tallclair
Copy link
Member

Should we include a v1beta1 verison of the configuration API as part of this?

@liggitt
Copy link
Member Author

liggitt commented Nov 2, 2021

yes, good point

@liggitt
Copy link
Member Author

liggitt commented Nov 2, 2021

added

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2021
@liggitt liggitt moved this from In Progress to In Review in SIG-Auth: PodSecurity Nov 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Nov 2, 2021

/retest

@liggitt liggitt added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 2, 2021
@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 2, 2021
@liggitt
Copy link
Member Author

liggitt commented Nov 3, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2021
@liggitt
Copy link
Member Author

liggitt commented Nov 3, 2021

/assign @enj

@liggitt
Copy link
Member Author

liggitt commented Nov 3, 2021

prereqs have merged, config version is updated as well

@liggitt liggitt mentioned this pull request Nov 3, 2021
Merged
@liggitt liggitt changed the title PodSecurity: promote to beta PodSecurity: promote config and feature gate to beta Nov 3, 2021
@enj
Copy link
Member

enj commented Nov 3, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2021
@liggitt
Copy link
Member Author

liggitt commented Nov 3, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9af2ece into kubernetes:master Nov 3, 2021
SIG-Auth: PodSecurity automation moved this from In Review to Done (1.23, Beta) Nov 3, 2021
@liggitt liggitt deleted the podsecurity-beta branch November 3, 2021 12:36
@liggitt liggitt mentioned this pull request Nov 3, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnSchnake johnSchnake Awaiting requested review from johnSchnake

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@enj enj

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Auth: PodSecurity
Done (1.23, Beta)
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @tallclair @k8s-ci-robot @enj