Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore VMs in vmss delete backend pools #105185

Merged
merged 1 commit into from Oct 1, 2021
Merged

Ignore VMs in vmss delete backend pools #105185

merged 1 commit into from Oct 1, 2021

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Sep 21, 2021 •
edited

/kind bug
/sig cloud-provider
/area provider/azure

This PR is a cherry-pick of kubernetes-sigs/cloud-provider-azure@941b787 from the out-of-tree azure CCM.

Fixes #105184

Does this PR introduce a user-facing change?

Fix: ignore not a VMSS error for VMAS nodes in EnsureBackendPoolDeleted.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@ialidzhikov
Ignore VMs in vmss delete backend pools
df845f0 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 21, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ialidzhikov
Copy link
Contributor Author

/cc @CecileRobertMichon @nilo19

@CecileRobertMichon
Copy link
Member

/ok-to-test

lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 21, 2021
@ialidzhikov ialidzhikov mentioned this pull request Sep 21, 2021
Closed
@feiskyer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2021
@feiskyer
Copy link
Member

/assign @andrewsykim

@ialidzhikov
Copy link
Contributor Author

ping @andrewsykim
for approval

1 similar comment
@ialidzhikov
Copy link
Contributor Author

ping @andrewsykim
for approval

@bridgetkromhout
Copy link
Member

/assign @cheftako

@cheftako
Copy link
Member

cheftako commented Oct 1, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, feiskyer, ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@cheftako
Copy link
Member

cheftako commented Oct 1, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 1, 2021
@cheftako
Copy link
Member

cheftako commented Oct 1, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 26365fa into kubernetes:master Oct 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 1, 2021
This was referenced Oct 1, 2021
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2021
@k8s-ci-robot
Merge pull request #105402 from ialidzhikov/automated-cherry-pick-of-…
5533776 
…#105185-upstream-release-1.21

Automated cherry pick of #105185: Ignore VMs in vmss delete backend pools
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2021
@k8s-ci-robot
Merge pull request #105400 from ialidzhikov/automated-cherry-pick-of-…
9292d29 
…#105185-upstream-release-1.22

Automated cherry pick of #105185: Ignore VMs in vmss delete backend pools
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2021
@k8s-ci-robot
Merge pull request #105404 from ialidzhikov/automated-cherry-pick-of-…
af669d8 
…#105185-upstream-release-1.20

Automated cherry pick of #105185: Ignore VMs in vmss delete backend pools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karataliu karataliu Awaiting requested review from karataliu

@nilo19 nilo19 Awaiting requested review from nilo19

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@feiskyer feiskyer

@cheftako cheftako

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Azure CCM: failed to delete load balancer: not a vmss instance
7 participants
@ialidzhikov @k8s-ci-robot @CecileRobertMichon @feiskyer @bridgetkromhout @cheftako @andrewsykim