Remove ignore error flag for drain, and set this feature as default #105571
Conversation
k8s-ci-robot
added
kind/cleanup
|
/assign @eddiezane |
k8s-ci-robot
added
the
lgtm
| continue | ||
| } | ||
|
|
||
| if len(remainingNodes) > 0 { |
There was a problem hiding this comment.
Something here looks off to me.
This top level for range is going through all of the nodes.
It then calls drain on the node.
If that errors it logs the error for the node, adds the node to remainingNodes, and continues the original for range.
If there is no error it prints the node was drained and then checks if there are remainingNodes in the list. These are the nodes that have errored.
We then go through those nodes that have errored and print out "There are pending nodes to be drained: ` with a list of all the failed nodes. This happens for each successfully drained node.
Is this the behavior we want?
There was a problem hiding this comment.
IMO, This happens for each successfully drained node. should only happen after all nodes has been done drain action
There was a problem hiding this comment.
Move this logic out of drain loop.
k8s-ci-robot
removed
the
lgtm
|
Gently ping @eddiezane for more review. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eddiezane, yuzhiquan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Remove ignore error flag for drain, and set this feature as default
Which issue(s) this PR fixes:
Refs #100052
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @dougsland @coderanger @eddiezane
/priority backlog
/triage accepted
/sig cli