Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: leave the probe path empty for TCP probes #105253

Merged
merged 1 commit into from Nov 1, 2021
Merged

fix: leave the probe path empty for TCP probes #105253

merged 1 commit into from Nov 1, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Sep 26, 2021

What type of PR is this?

What this PR does / why we need it:

fix: leave the probe path empty for TCP probes

Ref: kubernetes-sigs/cloud-provider-azure#680

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: leave the probe path empty for TCP probes

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig cloud-provider
/area provider/azure
/priority critical-urgent
/triage accepted
cc @feiskyer

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 26, 2021
@nilo19
Copy link
Member Author

nilo19 commented Sep 26, 2021

/retest

feiskyer
feiskyer approved these changes Sep 26, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 26, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2021
@andyzhangx
Copy link
Member

/retest

@nilo19
Copy link
Member Author

nilo19 commented Sep 29, 2021

/assign @andrewsykim for approval

@k8s-ci-robot
Copy link
Contributor

@nilo19: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @andrewsykim for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nilo19
Copy link
Member Author

nilo19 commented Oct 15, 2021

/assign @cheftako

@nilo19
Copy link
Member Author

nilo19 commented Oct 19, 2021

kindly ping @cheftako @andrewsykim

@nilo19
Copy link
Member Author

nilo19 commented Oct 28, 2021

kindly ping @cheftako @andrewsykim for approval

@cheftako
Copy link
Member

cheftako commented Nov 1, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 763e528 into kubernetes:master Nov 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 1, 2021
@nilo19 nilo19 deleted the bug/cherry-pick-680 branch November 2, 2021 01:36
This was referenced Nov 2, 2021
Merged
Merged
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 12, 2022
@k8s-ci-robot
Merge pull request #106077 from nilo19/automated-cherry-pick-of-#1052…
aaef1f4 
…53-upstream-release-1.20

Automated cherry pick of #105253: fix: leave the probe path empty for TCP probes
k8s-ci-robot added a commit that referenced this pull request Jan 12, 2022
@k8s-ci-robot
Merge pull request #106064 from nilo19/automated-cherry-pick-of-#1052…
01c5f75 
…53-upstream-release-1.21

Automated cherry pick of #105253: fix: leave the probe path empty for TCP probes
k8s-ci-robot added a commit that referenced this pull request Jan 12, 2022
@k8s-ci-robot
Merge pull request #106063 from nilo19/automated-cherry-pick-of-#1052…
bceef50 
…53-upstream-release-1.22

Automated cherry pick of #105253: fix: leave the probe path empty for TCP probes
@deads2k deads2k mentioned this pull request Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@karataliu karataliu Awaiting requested review from karataliu

Assignees

@feiskyer feiskyer

@cheftako cheftako

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nilo19 @andyzhangx @k8s-ci-robot @cheftako @feiskyer @andrewsykim