New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pause Images: Added base image for Windows Server 2022 #104438
Pause Images: Added base image for Windows Server 2022 #104438
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @nick5616! |
Hi @nick5616. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig windows |
/check-cla |
/ok-to-test |
/cc @claudiubelu |
/check-cla |
Successful build output DockerHub |
/retest |
Hello, thanks for the contribution! The commit looks good, I don't think we need any other changes. the image pause:3.6 has not been promoted from staging yet [1], so we don't have to bump the version either. I have also been able to build the image locally. After this PR merges, a PR should be opened here [1] and add the new pause image SHA, so it will be officially published. /lgtm |
/assign @BenTheElder @dims |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, nick5616 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit replaces Windows Server 2004, which has fallen out of support, with the newly supported Windows Server 2022 (kubernetes/kubernetes#104438).
This commit replaces Windows Server 2004, which has fallen out of support, with the newly supported Windows Server 2022 (kubernetes/kubernetes#104438).
This commit replaces Windows Server 2004, which has fallen out of support, with the newly supported Windows Server 2022 (kubernetes/kubernetes#104438).
This commit replaces Windows Server 2004, which has fallen out of support, with Windows Server 2022 (kubernetes/kubernetes#104438). The golden image referenced is baked with a private networking OS hotfix given by Microsoft for internal testing only.
This commit replaces Windows Server 2004, which has fallen out of support, with Windows Server 2022 (kubernetes/kubernetes#104438). The golden image referenced is baked with a private networking OS hotfix given by Microsoft for internal testing only. This commit houses a temporary split between the vSphere and platform=none jobs. Since the release repo points platform=none to use the 2004 golden image, in order for this PR to merge we need to pull compatible container images depending on the platform.
This commit replaces Windows Server 2004, which has fallen out of support, with Windows Server 2022 (kubernetes/kubernetes#104438). The golden image referenced is baked with a private networking OS hotfix given by Microsoft for internal testing only. This commit houses a temporary split between the vSphere and platform=none jobs. Since the release repo points platform=none to use the 2004 golden image, in order for this PR to merge we need to pull compatible container images depending on the platform.
This commit replaces Windows Server 2004, which has fallen out of support, with Windows Server 2022 (kubernetes/kubernetes#104438). The golden image referenced is baked with a private networking OS hotfix given by Microsoft for internal testing only. This commit houses a temporary split between the vSphere and platform=none jobs. Since the release repo points platform=none to use the 2004 golden image, in order for this PR to merge we need to pull compatible container images depending on the platform.
This commit replaces Windows Server 2004, which has fallen out of support, with Windows Server 2022 (kubernetes/kubernetes#104438). It points vSphere CI to use the new WS2022 golden image with Docker pre-installed and the OS-level container networking patch released by Microsoft: https://support.microsoft.com/en-us/topic/april-25-2022-kb5012637-os-build-20348-681-preview-2233d69c-d4a5-4be9-8c24-04a450861a8d This commit houses a temporary split between the vSphere and platform=none jobs. Since the release repo points platform=none to use the 2004 golden image, in order for this PR to merge we need to pull compatible container images depending on the platform. Squash of cherry picked commits: 3a63398, 4895766
This commit replaces Windows Server 2004, which has fallen out of support, with Windows Server 2022 (kubernetes/kubernetes#104438). The golden image referenced is baked with a private networking OS hotfix given by Microsoft for internal testing only. This commit houses a temporary split between the vSphere and platform=none jobs. Since the release repo points platform=none to use the 2004 golden image, in order for this PR to merge we need to pull compatible container images depending on the platform. (cherry picked from commit 3a63398)
This commit replaces Windows Server 2004, which has fallen out of support, with Windows Server 2022 (kubernetes/kubernetes#104438). The golden image referenced is baked with a private networking OS hotfix given by Microsoft for internal testing only. This commit houses a temporary split between the vSphere and platform=none jobs. Since the release repo points platform=none to use the 2004 golden image, in order for this PR to merge we need to pull compatible container images depending on the platform. (cherry picked from commit 3a63398)
This commit replaces Windows Server 2004, which has fallen out of support, with Windows Server 2022 (kubernetes/kubernetes#104438). The golden image referenced is baked with a private networking OS hotfix given by Microsoft for internal testing only. This commit houses a temporary split between the vSphere and platform=none jobs. Since the release repo points platform=none to use the 2004 golden image, in order for this PR to merge we need to pull compatible container images depending on the platform. (cherry picked from commit 3a63398)
This commit replaces Windows Server 2004, which has fallen out of support, with Windows Server 2022 (kubernetes/kubernetes#104438). It points vSphere CI to use the new WS2022 golden image with Docker pre-installed and the OS-level container networking patch released by Microsoft: https://support.microsoft.com/en-us/topic/april-25-2022-kb5012637-os-build-20348-681-preview-2233d69c-d4a5-4be9-8c24-04a450861a8d This commit houses a temporary split between the vSphere and platform=none jobs. Since the release repo points platform=none to use the 2004 golden image, in order for this PR to merge we need to pull compatible container images depending on the platform. Squash of cherry picked commits: 3a63398, 4895766
This commit replaces Windows Server 2004, which has fallen out of support, with Windows Server 2022 (kubernetes/kubernetes#104438). It points vSphere CI to use the new WS2022 golden image with Docker pre-installed and the OS-level container networking patch released by Microsoft: https://support.microsoft.com/en-us/topic/april-25-2022-kb5012637-os-build-20348-681-preview-2233d69c-d4a5-4be9-8c24-04a450861a8d This commit houses a temporary split between the vSphere and platform=none jobs. Since the release repo points platform=none to use the 2004 golden image, in order for this PR to merge we need to pull compatible container images depending on the platform. Squash of cherry picked commits: 3a63398, 4895766
What type of PR is this?
Enable new OS
/sig windows
/kind feature
What this PR does / why we need it:
Windows Server 2022 has become available. This PR adds Windows Server 2022 as a supported pause image
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: