New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the --csr* flags from "kubeadm certs renew" #104796
Conversation
/kind cleanup |
@RA489: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@RA489: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-kind deprecation |
/release-note-none |
/triage accepted |
As the CI show, unit test should be updated as well. kubernetes/cmd/kubeadm/app/cmd/certs_test.go Line 290 in cde45fb
|
/milestone v1.23 |
@RA489 please add the https://raw.githubusercontent.com/kubernetes/kubernetes/master/.github/PULL_REQUEST_TEMPLATE.md the release note should be:
|
@neolit123 added the release notes. Thanks!! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, RA489 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # kubernetes/kubeadm#2163
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: