New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn on CSIMigrationAzureDisk by default on 1.23 #104670
Conversation
/test pull-kubernetes-e2e-capz-azure-disk |
I think we might need to migrate the CI to cloud-provider-azure or install the azuredisk csi driver by default. |
@Jiawei0227 yes, I will fix it later |
one related PR: kubernetes/test-infra#23487 |
/test pull-kubernetes-e2e-capz-azure-disk |
/test pull-kubernetes-e2e-capz-azure-file |
1 similar comment
/test pull-kubernetes-e2e-capz-azure-file |
/test pull-kubernetes-e2e-capz-azure-disk |
/test pull-kubernetes-e2e-capz-azure-file |
/test pull-kubernetes-e2e-capz-azure-disk |
/retest |
/lgtm |
Seems on windows side it still need some setting? |
@Jiawei0227 that's windows test issue, I am still fixing it, need more time. |
/test pull-kubernetes-e2e-capz-azure-disk |
/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim |
2 similar comments
/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim |
/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim |
/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim |
/test pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim |
finally, I have fixed all tests with csi driver enabled, could you approve? thanks. |
/test pull-kubernetes-e2e-capz-azure-file-vmss |
/retest |
@msau42 for approval. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
turn on CSIMigrationAzureDisk by default on 1.23
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: