Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding deprecation notice to the userspace proxy-mode #104631

Merged
merged 1 commit into from Oct 6, 2021
Merged

Adding deprecation notice to the userspace proxy-mode #104631

merged 1 commit into from Oct 6, 2021

Conversation

perithompson
Copy link

@perithompson perithompson commented Aug 27, 2021 •
edited

This PR adds a deprecation notice for the userspace kube-proxy that needs to be removed, the reasons behind this are documented it #103860

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

Userspace proxy has essentially become unsupported in kube-proxy and recently sig-network has decided to remove the userspace linux and windows proxies from kubernetes core. As part of this work we need to add a deprecation warning when running with userspace proxy that this is now deprecated and another proxy mode should be used.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

related to
#103860

Does this PR introduce a user-facing change?

A deprecation notice has been added when using the kube-proxy Userspace proxier, which will be removed in v1.25. (#103860)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 27, 2021
@k8s-ci-robot
Copy link
Contributor

@perithompson: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@perithompson: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2021
@perithompson
Copy link
Author

@jayunit100 started this here, not sure if I can mark the flag as deprecated because its only one option, not the whole flag

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 27, 2021
@perithompson
Copy link
Author

/cc @jayunit100
/sig network

@perithompson
Copy link
Author

@jayunit100 PTAL and let me know if you wanted more comments anywhere else?

@perithompson perithompson changed the title WIP: Adding deprecation notice to the userspace proxy-mode Adding deprecation notice to the userspace proxy-mode Aug 31, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2021
@khenidak
Copy link
Contributor

khenidak commented Sep 3, 2021

/assign @khenidak

Please add a release note so we can merge this one.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 13, 2021
@khenidak
Copy link
Contributor

khenidak commented Oct 6, 2021

/lgtm
/approve

@khenidak
Copy link
Contributor

khenidak commented Oct 6, 2021

Thanks for this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khenidak, perithompson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2021
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@aojea
Copy link
Member

aojea commented Oct 6, 2021

/cc @danwinship
Thanks

@k8s-ci-robot k8s-ci-robot merged commit 84027bc into kubernetes:master Oct 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 6, 2021
@aojea aojea mentioned this pull request Oct 11, 2021
Merged
@aojea aojea mentioned this pull request Mar 21, 2022
Closed
@sftim sftim mentioned this pull request Mar 22, 2022
Closed
@pandaamanda pandaamanda mentioned this pull request Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn Awaiting requested review from MrHohn

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@khenidak khenidak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@perithompson @k8s-ci-robot @khenidak @k8s-triage-robot @aojea