New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip case sensitivity when checking Azure NSG rules #104384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
kind/bug
Categorizes issue or PR as related to a bug.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
sig/cloud-provider
Categorizes an issue or PR as relevant to SIG Cloud Provider.
area/provider/azure
Issues or PRs related to azure provider
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
labels
Aug 16, 2021
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Aug 17, 2021
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Aug 19, 2021
This was referenced Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/cloudprovider
area/provider/azure
Issues or PRs related to azure provider
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/cloud-provider
Categorizes an issue or PR as relevant to SIG Cloud Provider.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/sig cloud-provider
/area provider/azure
/priority critical-urgent
/triage accepted
What this PR does / why we need it:
cherry-pick bug fix from out-of-tree cloud provider kubernetes-sigs/cloud-provider-azure#741: skip case sensitivity when checking Azure NSG rules
Which issue(s) this PR fixes:
Fixes kubernetes-sigs/cloud-provider-azure#740
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: