kubelet: also provide filesystem stats for generic ephemeral volumes #105569
Conversation
k8s-ci-robot
added
release-note
|
@pohly: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-priority
k8s-ci-robot
added
area/kubelet
sig/node
When checking for a reference to a PVC, the code also needs to consider that a PVC might be referenced indirectly through an ephemeral volume source.
pohly
force-pushed
the
generic-ephemeral-kubelet-volume-stats
branch
from
bd8b5b9
to
b1ba381
Compare
| assert.Contains(t, append(vs.EphemeralVolumes, vs.PersistentVolumes...), kubestats.VolumeStats{ | ||
| Name: vol3, | ||
| PVCRef: &kubestats.PVCReference{ | ||
| Name: pName0 + "-" + vol3, |
There was a problem hiding this comment.
Do you want to use the helper referenced in the following for this: https://github.com/kubernetes/kubernetes/pull/105542/files#diff-e81aa7518bebe9f4412cb375a9008b3481b19ec3e851d3187b3021ee94148f0dR2044
Or is there no way to use that for the purpose of this test?
There was a problem hiding this comment.
I intentionally wanted to avoid using the helper function here because it kind of is part of what's under test here. Testing code by invoking the code itself seemed a bit fishy.
On the other hand, one can argue that the helper function can be assumed to work and thus isn't what is getting test here.
In the end I don't have a strong preference.
There was a problem hiding this comment.
That aside, using the helper function is more complicated (needs fuil pod and PVC objects).
There was a problem hiding this comment.
No worries. Just making sure it wasn't an oversight since the other change is only just now being introduced.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: klueska, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind bug
What this PR does / why we need it:
When checking for a reference to a PVC, the code also needs to consider that a
PVC might be referenced indirectly through an ephemeral volume source.
Which issue(s) this PR fixes:
Reported on Slack: https://kubernetes.slack.com/archives/C09QZFCE5/p1633675452222400
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: