Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate cmd/kube-proxy/app logs to structured logging #98913

Merged
merged 1 commit into from Aug 6, 2021
Merged

migrate cmd/kube-proxy/app logs to structured logging #98913

merged 1 commit into from Aug 6, 2021

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Feb 9, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
part of kubernetes/enhancements#1602

Which issue(s) this PR fixes:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

migratecmd/kube-proxy/app logs to structured logging

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 9, 2021
@k8s-ci-robot
Copy link
Contributor

@yxxhero: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @yxxhero. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2021
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 9, 2021
@yxxhero
Copy link
Member Author

yxxhero commented Feb 9, 2021

/cc @rramkumar1 @MrHohn Thank very much.

@Cweiping
Copy link

Cweiping commented Feb 9, 2021

Thank you for your contribution.
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2021
@yxxhero
Copy link
Member Author

yxxhero commented Feb 9, 2021

/retest

1 similar comment
@yxxhero
Copy link
Member Author

yxxhero commented Feb 9, 2021

/retest

@yxxhero
Copy link
Member Author

yxxhero commented Feb 9, 2021

@Cweiping The test is all ok. what should I do next? Thanks very much.

@Cweiping
Copy link

@Cweiping The test is all ok. what should I do next? Thanks very much.

Nothing, thx!
/lgtm
/assign @bowei

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2021
@yxxhero
Copy link
Member Author

yxxhero commented Feb 18, 2021

Looking forward to your review. Thanks very much @bowei

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 18, 2021
@yxxhero yxxhero force-pushed the cmd_kube_proxy_app_structured_logging branch from 825fa84 to e52ca09 Compare February 19, 2021 00:41
@yxxhero
Copy link
Member Author

yxxhero commented Jul 20, 2021

/retest

aojea
aojea reviewed Jul 20, 2021
View reviewed changes
cmd/kube-proxy/app/server_others.go Outdated
@@ -271,9 +271,9 @@ func newProxyServer(
}
proxymetrics.RegisterMetrics()
} else if proxyMode == proxyModeIPVS {
klog.V(0).Info("Using ipvs Proxier.")
klog.V(0).InfoS("Using ipvs Proxier.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've removed all trailing dots but this 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In pursuit of perfection, I will fix it. Thanks very much.

@aojea
Copy link
Member

aojea commented Jul 20, 2021

/lgtm
/approve
just a nit missing

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, yxxhero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2021
@yxxhero yxxhero force-pushed the cmd_kube_proxy_app_structured_logging branch from 99f480b to 38239d3 Compare July 20, 2021 15:08
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@yxxhero yxxhero requested a review from aojea July 20, 2021 15:09
@yxxhero
Copy link
Member Author

yxxhero commented Jul 20, 2021

@aojea Looking forward to your review. Thanks very much.

@aojea
Copy link
Member

aojea commented Jul 20, 2021

/lgtm
Thanks
However, I don't know if this will qualify for 1.22, I'm not familiar with the structured logging implementation plans

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@yxxhero
Copy link
Member Author

yxxhero commented Jul 20, 2021

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@aojea Thanks very much again. this issue require /hold comment?

@aojea
Copy link
Member

aojea commented Jul 21, 2021

@aojea Thanks very much again. this issue require /hold comment?

No, that's the bot that retried a failing job.
Currently kubernetes is in code freeze, The PR will not be able to merge until 1.22 is released.
Is okay , we should just wait a few weeks until master opens again

@yxxhero
Copy link
Member Author

yxxhero commented Jul 21, 2021

@aojea Thanks very much again.

@yxxhero
Copy link
Member Author

yxxhero commented Aug 4, 2021

/retest

@k8s-triage-robot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@yxxhero
Copy link
Member Author

yxxhero commented Aug 5, 2021

/retest

2 similar comments
@dims
Copy link
Member

dims commented Aug 5, 2021

/retest

@yxxhero
Copy link
Member Author

yxxhero commented Aug 5, 2021

/retest

@yxxhero
Copy link
Member Author

yxxhero commented Aug 5, 2021

/test pull-kubernetes-integration

@k8s-triage-robot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@yxxhero
Copy link
Member Author

yxxhero commented Aug 6, 2021

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 44e2723 into kubernetes:master Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 6, 2021
@shiva1333 shiva1333 mentioned this pull request Sep 9, 2021
Closed
@yxxhero yxxhero mentioned this pull request Nov 13, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn Awaiting requested review from MrHohn

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

@ehashman ehashman Awaiting requested review from ehashman

@yangjunmyfm192085 yangjunmyfm192085 Awaiting requested review from yangjunmyfm192085

@aojea aojea Awaiting requested review from aojea

Assignees

@bowei bowei

@aojea aojea

@Cweiping Cweiping

@yangjunmyfm192085 yangjunmyfm192085

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
WG Structured Logging - Migration Rev...
Needs Review
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@yxxhero @k8s-ci-robot @Cweiping @yangjunmyfm192085 @aojea @fejta-bot @k8s-triage-robot @dims @bowei