Hi @yxxhero. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test
/assign @dgrisonnet

/retitle Remove StartedPodsErrorsTotal metric message
/triage accepted

/test pull-kubernetes-node-e2e-containerd

/lgtm

@slashpai: changing LGTM is restricted to collaborators

The root cause maybe m.createPodSandbox(pod, podContainerChanges.Attempt) does not return well-defined error codes that have reasonable cardinality for metrics, like Line 891 below:

var (
	// ErrCreateContainerConfig - failed to create container config
	ErrCreateContainerConfig = errors.New("CreateContainerConfigError")
	// ErrPreCreateHook - failed to execute PreCreateHook
	ErrPreCreateHook = errors.New("PreCreateHookError")
	// ErrCreateContainer - failed to create container
	ErrCreateContainer = errors.New("CreateContainerError")
	// ErrPreStartHook - failed to execute PreStartHook
	ErrPreStartHook = errors.New("PreStartHookError")
	// ErrPostStartHook - failed to execute PostStartHook
	ErrPostStartHook = errors.New("PostStartHookError")
)

@249043822 i will see it. Thanks very much.

I agree with @249043822, instead of removing the error message completely we should log it if it isn't already the case and create error codes based on them. It would be great to be able to group them between error reasons (in a similar format as the Event reasons) and expose them in the metric via a reason label.

@249043822 @dgrisonnet ok, I will do as you say. Thanks very much.

@dgrisonnet We already log the error on L819:

I think anything else beyond that isn't targeted enough for a bugfix.

Can we possibly get a release note on here? Something like "Removed error message label from kubelet_started_pods_errors_total metric"

Makes sense 👍

/lgtm

/release-note-edit release-note Removed error message label from kubelet_started_pods_errors_total metric

I don't think the release note editing bot is live yet :)

@ehashman @dgrisonnet I already add the release note. Thanks very much.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, yxxhero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Could we have this PR backported to 1.22? This would allow cleaning up the metric on all the releases that include it.